The patch titled Subject: fs/dcache: avoid unused-function warning has been added to the -mm tree. Its filename is fs-move-dcache-sysctls-to-its-own-file-fix-2.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/fs-move-dcache-sysctls-to-its-own-file-fix-2.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/fs-move-dcache-sysctls-to-its-own-file-fix-2.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Arnd Bergmann <arnd@xxxxxxxx> Subject: fs/dcache: avoid unused-function warning Now that 'dentry_stat' is marked 'static', we can run into this warning: fs/dcache.c:128:29: error: 'dentry_stat' defined but not used [-Werror=unused-variable] 128 | static struct dentry_stat_t dentry_stat = { Hide it in the same #ifdef as its only references. Link: https://lkml.kernel.org/r/20211203190123.874239-2-arnd@xxxxxxxxxx Fixes: f0eea17ca8da ("fs: move dcache sysctls to its own file") Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/dcache.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/fs/dcache.c~fs-move-dcache-sysctls-to-its-own-file-fix-2 +++ a/fs/dcache.c @@ -124,16 +124,15 @@ struct dentry_stat_t { long dummy; /* Reserved for future use */ }; -/* Statistics gathering. */ -static struct dentry_stat_t dentry_stat = { - .age_limit = 45, -}; - static DEFINE_PER_CPU(long, nr_dentry); static DEFINE_PER_CPU(long, nr_dentry_unused); static DEFINE_PER_CPU(long, nr_dentry_negative); #if defined(CONFIG_SYSCTL) && defined(CONFIG_PROC_FS) +/* Statistics gathering. */ +static struct dentry_stat_t dentry_stat = { + .age_limit = 45, +}; /* * Here we resort to our own counters instead of using generic per-cpu counters _ Patches currently in -mm which might be from arnd@xxxxxxxx are fs-move-inode-sysctls-to-its-own-file-fix.patch fs-move-dcache-sysctls-to-its-own-file-fix-2.patch