The patch titled Subject: selftests/damon: test DAMON enabling with empty target_ids case has been added to the -mm tree. Its filename is selftests-damon-test-damon-enabling-with-empty-target_ids-case.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/selftests-damon-test-damon-enabling-with-empty-target_ids-case.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/selftests-damon-test-damon-enabling-with-empty-target_ids-case.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: SeongJae Park <sj@xxxxxxxxxx> Subject: selftests/damon: test DAMON enabling with empty target_ids case DAMON debugfs didn't check empty targets when starting monitoring, and the issue is fixed with commit b5ca3e83ddb0 ("mm/damon/dbgfs: add adaptive_targets list check before enable monitor_on"). To avoid future regression, this commit adds a test case for that in DAMON selftests. Link: https://lkml.kernel.org/r/20211201150440.1088-9-sj@xxxxxxxxxx Signed-off-by: SeongJae Park <sj@xxxxxxxxxx> Cc: Brendan Higgins <brendanhiggins@xxxxxxxxxx> Cc: Shuah Khan <shuah@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- tools/testing/selftests/damon/debugfs_attrs.sh | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/tools/testing/selftests/damon/debugfs_attrs.sh~selftests-damon-test-damon-enabling-with-empty-target_ids-case +++ a/tools/testing/selftests/damon/debugfs_attrs.sh @@ -94,4 +94,13 @@ test_write_succ "$file" "" "$orig_conten test_content "$file" "$orig_content" "" "empty input written" echo "$orig_content" > "$file" +# Test empty targets case +# ======================= + +orig_target_ids=$(cat "$DBGFS/target_ids") +echo "" > "$DBGFS/target_ids" +orig_monitor_on=$(cat "$DBGFS/monitor_on") +test_write_fail "$DBGFS/monitor_on" "on" "orig_monitor_on" "empty target ids" +echo "$orig_target_ids" > "$DBGFS/target_ids" + echo "PASS" _ Patches currently in -mm which might be from sj@xxxxxxxxxx are timers-implement-usleep_idle_range.patch mm-damon-core-fix-fake-load-reports-due-to-uninterruptible-sleeps.patch mm-damon-core-use-better-timer-mechanisms-selection-threshold.patch mm-damon-dbgfs-remove-an-unnecessary-error-message.patch mm-damon-core-remove-unnecessary-error-messages.patch mm-damon-vaddr-remove-an-unnecessary-warning-message.patch mm-damon-vaddr-test-split-a-test-function-having-1024-bytes-frame-size.patch mm-damon-vaddr-test-remove-unnecessary-variables.patch selftests-damon-skip-test-if-damon-is-running.patch selftests-damon-test-damon-enabling-with-empty-target_ids-case.patch selftests-damon-test-wrong-damos-condition-ranges-input.patch selftests-damon-test-debugfs-file-reads-writes-with-huge-count.patch selftests-damon-split-test-cases.patch mm-damon-remove-some-no-need-func-definitions-in-damonh-file-fix.patch