The patch titled
Subject: mm: don't read i_size of inode unless we need it
has been added to the -mm tree. Its filename is
mm-dont-read-i_size-of-inode-unless-we-need-it.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-dont-read-i_size-of-inode-unless-we-need-it.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-dont-read-i_size-of-inode-unless-we-need-it.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Jens Axboe <axboe@xxxxxxxxx>
Subject: mm: don't read i_size of inode unless we need it
We always go through i_size_read(), and we rarely end up needing it. Push
the read to down where we need to check it, which avoids it for most
cases.
It looks like we can even remove this check entirely, which might be
worth pursuing. But at least this takes it out of the hot path.
Link: https://lkml.kernel.org/r/6b67981f-57d4-c80e-bc07-6020aa601381@xxxxxxxxx
Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
Acked-by: Chris Mason <clm@xxxxxx>
Cc: Josef Bacik <josef@xxxxxxxxxx>
Cc: Dave Chinner <david@xxxxxxxxxxxxx>
Cc: Pavel Begunkov <asml.silence@xxxxxxxxx>
Cc: Jan Kara <jack@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/filemap.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/mm/filemap.c~mm-dont-read-i_size-of-inode-unless-we-need-it
+++ a/mm/filemap.c
@@ -2740,9 +2740,7 @@ generic_file_read_iter(struct kiocb *ioc
struct file *file = iocb->ki_filp;
struct address_space *mapping = file->f_mapping;
struct inode *inode = mapping->host;
- loff_t size;
- size = i_size_read(inode);
if (iocb->ki_flags & IOCB_NOWAIT) {
if (filemap_range_needs_writeback(mapping, iocb->ki_pos,
iocb->ki_pos + count - 1))
@@ -2774,8 +2772,9 @@ generic_file_read_iter(struct kiocb *ioc
* the rest of the read. Buffered reads will not work for
* DAX files, so don't bother trying.
*/
- if (retval < 0 || !count || iocb->ki_pos >= size ||
- IS_DAX(inode))
+ if (retval < 0 || !count || IS_DAX(inode))
+ return retval;
+ if (iocb->ki_pos >= i_size_read(inode))
return retval;
}
_
Patches currently in -mm which might be from axboe@xxxxxxxxx are
mm-dont-read-i_size-of-inode-unless-we-need-it.patch
mm-move-more-expensive-part-of-xa-setup-out-of-mapping-check.patch
