The patch titled Subject: Docs/admin-guide/mm/damon/start: fix wrong example commands has been added to the -mm tree. Its filename is docs-admin-guide-mm-damon-start-fix-wrong-example-commands.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/docs-admin-guide-mm-damon-start-fix-wrong-example-commands.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/docs-admin-guide-mm-damon-start-fix-wrong-example-commands.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: SeongJae Park <sj@xxxxxxxxxx> Subject: Docs/admin-guide/mm/damon/start: fix wrong example commands Patch series "Fix trivial nits in Documentation/admin-guide/mm". This patchset fixes trivial nits in admin guide documents for DAMON and pagemap. This patch (of 4): Some of the example commands in DAMON getting started guide are outdated, missing sudo, or just wrong. This commit fixes those. Link: https://lkml.kernel.org/r/20211022090311.3856-2-sj@xxxxxxxxxx Signed-off-by: SeongJae Park <sj@xxxxxxxxxx> Cc: Jonathan Corbet <corbet@xxxxxxx> Cc: Peter Xu <peterx@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- Documentation/admin-guide/mm/damon/start.rst | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) --- a/Documentation/admin-guide/mm/damon/start.rst~docs-admin-guide-mm-damon-start-fix-wrong-example-commands +++ a/Documentation/admin-guide/mm/damon/start.rst @@ -19,7 +19,7 @@ your workload. :: # mount -t debugfs none /sys/kernel/debug/ # git clone https://github.com/awslabs/damo # ./damo/damo record $(pidof <your workload>) - # ./damo/damo report heat --plot_ascii + # ./damo/damo report heats --heatmap stdout The final command draws the access heatmap of ``<your workload>``. The heatmap shows which memory region (x-axis) is accessed when (y-axis) and how frequently @@ -94,9 +94,9 @@ Visualizing Recorded Patterns The following three commands visualize the recorded access patterns and save the results as separate image files. :: - $ damo report heats --heatmap access_pattern_heatmap.png - $ damo report wss --range 0 101 1 --plot wss_dist.png - $ damo report wss --range 0 101 1 --sortby time --plot wss_chron_change.png + $ sudo damo report heats --heatmap access_pattern_heatmap.png + $ sudo damo report wss --range 0 101 1 --plot wss_dist.png + $ sudo damo report wss --range 0 101 1 --sortby time --plot wss_chron_change.png - ``access_pattern_heatmap.png`` will visualize the data access pattern in a heatmap, showing which memory region (y-axis) got accessed when (x-axis) @@ -115,9 +115,9 @@ Data Access Pattern Aware Memory Managem Below three commands make every memory region of size >=4K that doesn't accessed for >=60 seconds in your workload to be swapped out. :: - $ echo "#min-size max-size min-acc max-acc min-age max-age action" > scheme - $ echo "4K max 0 0 60s max pageout" >> scheme - $ damo schemes -c my_thp_scheme <pid of your workload> + $ echo "#min-size max-size min-acc max-acc min-age max-age action" > test_scheme + $ echo "4K max 0 0 60s max pageout" >> test_scheme + $ damo schemes -c test_scheme <pid of your workload> .. [1] https://damonitor.github.io/doc/html/v17/admin-guide/mm/damon/start.html#visualizing-recorded-patterns .. [2] https://damonitor.github.io/test/result/visual/latest/rec.heatmap.1.png.html _ Patches currently in -mm which might be from sj@xxxxxxxxxx are maintainers-update-seongjaes-email-address.patch mm-damon-core-print-kdamond-start-log-in-debug-mode-only.patch mm-damon-core-account-age-of-target-regions.patch mm-damon-core-implement-damon-based-operation-schemes-damos.patch mm-damon-vaddr-support-damon-based-operation-schemes.patch mm-damon-dbgfs-support-damon-based-operation-schemes.patch mm-damon-schemes-implement-statistics-feature.patch selftests-damon-add-schemes-debugfs-tests.patch docs-admin-guide-mm-damon-document-damon-based-operation-schemes.patch mm-damon-dbgfs-allow-users-to-set-initial-monitoring-target-regions.patch mm-damon-dbgfs-test-add-a-unit-test-case-for-init_regions.patch docs-admin-guide-mm-damon-document-init_regions-feature.patch mm-damon-vaddr-separate-commonly-usable-functions.patch mm-damon-vaddr-separate-commonly-usable-functions-fix.patch mm-damon-implement-primitives-for-physical-address-space-monitoring.patch mm-damon-dbgfs-support-physical-memory-monitoring.patch docs-damon-document-physical-memory-monitoring-support.patch mm-damon-paddr-support-the-pageout-scheme.patch mm-damon-schemes-implement-size-quota-for-schemes-application-speed-control.patch mm-damon-schemes-skip-already-charged-targets-and-regions.patch mm-damon-schemes-implement-time-quota.patch mm-damon-dbgfs-support-quotas-of-schemes.patch mm-damon-selftests-support-schemes-quotas.patch mm-damon-schemes-prioritize-regions-within-the-quotas.patch mm-damon-vaddrpaddr-support-pageout-prioritization.patch mm-damon-dbgfs-support-prioritization-weights.patch tools-selftests-damon-update-for-regions-prioritization-of-schemes.patch mm-damon-schemes-activate-schemes-based-on-a-watermarks-mechanism.patch mm-damon-dbgfs-support-watermarks.patch selftests-damon-support-watermarks.patch mm-damon-introduce-damon-based-reclamation-damon_reclaim.patch documentation-admin-guide-mm-damon-add-a-document-for-damon_reclaim.patch docs-admin-guide-mm-damon-start-fix-wrong-example-commands.patch docs-admin-guide-mm-damon-start-fix-a-wrong-link.patch docs-admin-guide-mm-damon-start-simplify-the-content.patch docs-admin-guide-mm-pagemap-wordsmith-page-flags-descriptions.patch