The patch titled
Subject: mm/mprotect.c: avoid repeated assignment in do_mprotect_pkey()
has been added to the -mm tree. Its filename is
mm-mprotectc-avoid-repeated-assignment-in-do_mprotect_pkey.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-mprotectc-avoid-repeated-assignment-in-do_mprotect_pkey.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-mprotectc-avoid-repeated-assignment-in-do_mprotect_pkey.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Liu Song <liu.song11@xxxxxxxxxx>
Subject: mm/mprotect.c: avoid repeated assignment in do_mprotect_pkey()
After adjustment, the repeated assignment of "prev" is avoided, and the
readability of the code is improved.
Link: https://lkml.kernel.org/r/20211012152444.4127-1-fishland@xxxxxxxxxx
Signed-off-by: Liu Song <liu.song11@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/mprotect.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/mm/mprotect.c~mm-mprotectc-avoid-repeated-assignment-in-do_mprotect_pkey
+++ a/mm/mprotect.c
@@ -563,7 +563,7 @@ static int do_mprotect_pkey(unsigned lon
error = -ENOMEM;
if (!vma)
goto out;
- prev = vma->vm_prev;
+
if (unlikely(grows & PROT_GROWSDOWN)) {
if (vma->vm_start >= end)
goto out;
@@ -581,8 +581,11 @@ static int do_mprotect_pkey(unsigned lon
goto out;
}
}
+
if (start > vma->vm_start)
prev = vma;
+ else
+ prev = vma->vm_prev;
for (nstart = start ; ; ) {
unsigned long mask_off_old_flags;
_
Patches currently in -mm which might be from liu.song11@xxxxxxxxxx are
mm-mprotectc-avoid-repeated-assignment-in-do_mprotect_pkey.patch
