The patch titled
usb: ati remote memleak fix
has been added to the -mm tree. Its filename is
usb-ati-remote-memleak-fix.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: usb: ati remote memleak fix
From: Mariusz Kozlowski <m.kozlowski@xxxxxxxxxx>
This is a bug. When checking for ati_remote->outbuf we free freeing
ati_remote->inbuf so we end up freeing ati_remote->inbuf twice.
Also the checks for 'ati_remote->inbuf != NULL' and 'ati_remote->outbuf !=
NULL' are redundant as usb_buffer_free() does this.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@xxxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/usb/input/ati_remote.c | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff -puN drivers/usb/input/ati_remote.c~usb-ati-remote-memleak-fix drivers/usb/input/ati_remote.c
--- a/drivers/usb/input/ati_remote.c~usb-ati-remote-memleak-fix
+++ a/drivers/usb/input/ati_remote.c
@@ -633,13 +633,11 @@ static void ati_remote_free_buffers(stru
usb_free_urb(ati_remote->irq_urb);
usb_free_urb(ati_remote->out_urb);
- if (ati_remote->inbuf)
- usb_buffer_free(ati_remote->udev, DATA_BUFSIZE,
- ati_remote->inbuf, ati_remote->inbuf_dma);
-
- if (ati_remote->outbuf)
- usb_buffer_free(ati_remote->udev, DATA_BUFSIZE,
- ati_remote->inbuf, ati_remote->outbuf_dma);
+ usb_buffer_free(ati_remote->udev, DATA_BUFSIZE,
+ ati_remote->inbuf, ati_remote->inbuf_dma);
+
+ usb_buffer_free(ati_remote->udev, DATA_BUFSIZE,
+ ati_remote->outbuf, ati_remote->outbuf_dma);
}
static void ati_remote_input_init(struct ati_remote *ati_remote)
_
Patches currently in -mm which might be from m.kozlowski@xxxxxxxxxx are
origin.patch
usb-idmouse-cleanup.patch
usb-writing_usb_driver-free-urb-cleanup.patch
usb-pcwd_usb-free-urb-cleanup.patch
usb-iforce-usb-free-urb-cleanup.patch
usb-usb-gigaset-free-kill-urb-cleanup.patch
usb-cinergyt2-free-kill-urb-cleanup.patch
usb-ttusb_dec-free-urb-cleanup.patch
usb-pvrusb2-hdw-free-unlink-urb-cleanup.patch
usb-pvrusb2-io-free-urb-cleanup.patch
usb-pwc-if-free-urb-cleanup.patch
usb-quickcam_messenger-free-urb-cleanup.patch
usb-irda-usb-free-urb-cleanup.patch
usb-zd1201-free-urb-cleanup.patch
usb-ati_remote-free-urb-cleanup.patch
usb-ati_remote2-free-urb-cleanup.patch
usb-hid-core-free-urb-cleanup.patch
usb-usbkbd-free-urb-cleanup.patch
usb-auerswald-free-kill-urb-cleanup-and-memleak-fix.patch
usb-phidgetkit-free-urb-cleanup.patch
usb-legousbtower-free-kill-urb-cleanup.patch
usb-phidgetmotorcontrol-free-urb-cleanup.patch
usb-catc-free-urb-cleanup.patch
usb-ftdi_sio-kill-urb-cleanup.patch
usb-io_edgeport-kill-urb-cleanup.patch
usb-keyspan-free-urb-cleanup.patch
usb-kobil_sct-kill-urb-cleanup.patch
usb-mct_u232-free-urb-cleanup.patch
usb-navman-kill-urb-cleanup.patch
usb-usb-serial-free-urb-cleanup.patch
usb-visor-kill-urb-cleanup.patch
usb-usbmidi-kill-urb-cleanup.patch
usb-usbmixer-free-kill-urb-cleanup.patch
usb-pwc-if-loop-fix.patch
usb-ati-remote-memleak-fix.patch
i2lib-unused-variable-cleanup.patch
make-1-bit-bitfields-unsigned.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
