The patch titled Subject: mm/hwpoison: remove unneeded variable unmap_success has been added to the -mm tree. Its filename is mm-hwpoison-remove-unneeded-variable-unmap_success.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/mm-hwpoison-remove-unneeded-variable-unmap_success.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/mm-hwpoison-remove-unneeded-variable-unmap_success.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Miaohe Lin <linmiaohe@xxxxxxxxxx> Subject: mm/hwpoison: remove unneeded variable unmap_success Patch series "Cleanups and fixup for hwpoison" This series contains cleanups to remove unneeded variable, fix some obsolete comments and so on. Also we fix potential pte_unmap_unlock on wrong pte. More details can be found in the respective changelogs. This patch (of 4): unmap_success is used to indicate whether page is successfully unmapped but it's irrelated with ZONE_DEVICE page and unmap_success is always true here. Remove this unneeded one. Link: https://lkml.kernel.org/r/20210814105131.48814-1-linmiaohe@xxxxxxxxxx Link: https://lkml.kernel.org/r/20210814105131.48814-2-linmiaohe@xxxxxxxxxx Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> Cc: Naoya Horiguchi <naoya.horiguchi@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/memory-failure.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/mm/memory-failure.c~mm-hwpoison-remove-unneeded-variable-unmap_success +++ a/mm/memory-failure.c @@ -1512,7 +1512,6 @@ static int memory_failure_dev_pagemap(un struct dev_pagemap *pgmap) { struct page *page = pfn_to_page(pfn); - const bool unmap_success = true; unsigned long size = 0; struct to_kill *tk; LIST_HEAD(tokill); @@ -1584,7 +1583,7 @@ static int memory_failure_dev_pagemap(un start = (page->index << PAGE_SHIFT) & ~(size - 1); unmap_mapping_range(page->mapping, start, size, 0); } - kill_procs(&tokill, flags & MF_MUST_KILL, !unmap_success, pfn, flags); + kill_procs(&tokill, flags & MF_MUST_KILL, false, pfn, flags); rc = 0; unlock: dax_unlock_page(page, cookie); _ Patches currently in -mm which might be from linmiaohe@xxxxxxxxxx are mm-gup-remove-set-but-unused-local-variable-major.patch mm-gup-remove-unneed-local-variable-orig_refs.patch mm-gup-remove-useless-bug_on-in-__get_user_pages.patch mm-gup-fix-potential-pgmap-refcnt-leak-in-__gup_device_huge.patch mm-gup-use-helper-page_aligned-in-populate_vma_page_range.patch shmem-remove-unneeded-variable-ret.patch shmem-remove-unneeded-header-file.patch shmem-remove-unneeded-function-forward-declaration.patch shmem-include-header-file-to-declare-swap_info.patch mm-memcg-remove-unused-functions.patch mm-memcg-save-some-atomic-ops-when-flush-is-already-true.patch mm-hwpoison-remove-unneeded-variable-unmap_success.patch mm-hwpoison-fix-potential-pte_unmap_unlock-pte-error.patch mm-hwpoison-change-argument-struct-page-hpagep-to-hpage.patch mm-hwpoison-fix-some-obsolete-comments.patch mm-vmscan-remove-the-pagedirty-check-after-madv_free-pages-are-page_ref_freezed.patch mm-vmscan-remove-misleading-setting-to-sc-priority.patch mm-vmscan-remove-unneeded-return-value-of-kswapd_run.patch mm-vmscan-add-else-to-remove-check_pending-label.patch mm-vmstat-correct-some-wrong-comments.patch mm-vmstat-simplify-the-array-size-calculation.patch mm-vmstat-remove-unneeded-return-value.patch mm-zsmallocc-close-race-window-between-zs_pool_dec_isolated-and-zs_unregister_migration.patch mm-zsmallocc-combine-two-atomic-ops-in-zs_pool_dec_isolated.patch