The patch titled
Subject: mm/vmscan: fix misleading comment in isolate_lru_pages()
has been added to the -mm tree. Its filename is
mm-vmscan-fix-misleading-comment-in-isolate_lru_pages.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-vmscan-fix-misleading-comment-in-isolate_lru_pages.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmscan-fix-misleading-comment-in-isolate_lru_pages.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Subject: mm/vmscan: fix misleading comment in isolate_lru_pages()
We couldn't know whether the page is being freed elsewhere until we failed
to increase the page count.
Link: https://lkml.kernel.org/r/20210710100329.49174-6-linmiaohe@xxxxxxxxxx
Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Cc: Alex Shi <alexs@xxxxxxxxxx>
Cc: Alistair Popple <apopple@xxxxxxxxxx>
Cc: David Hildenbrand <david@xxxxxxxxxx>
Cc: Hillf Danton <hillf.zj@xxxxxxxxxxxxxxx>
Cc: Jens Axboe <axboe@xxxxxxxxx>
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxx>
Cc: Minchan Kim <minchan@xxxxxxxxxx>
Cc: Shaohua Li <shli@xxxxxx>
Cc: Vlastimil Babka <vbabka@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/vmscan.c~mm-vmscan-fix-misleading-comment-in-isolate_lru_pages
+++ a/mm/vmscan.c
@@ -1891,7 +1891,6 @@ static unsigned long isolate_lru_pages(u
*/
scan += nr_pages;
if (!__isolate_lru_page_prepare(page, mode)) {
- /* It is being freed elsewhere */
list_move(&page->lru, src);
continue;
}
@@ -1901,6 +1900,7 @@ static unsigned long isolate_lru_pages(u
* page release code relies on it.
*/
if (unlikely(!get_page_unless_zero(page))) {
+ /* It is being freed elsewhere. */
list_move(&page->lru, src);
continue;
}
_
Patches currently in -mm which might be from linmiaohe@xxxxxxxxxx are
mm-vmscan-put-the-redirtied-madv_free-pages-back-to-anonymous-lru-list.patch
mm-vmscan-remove-misleading-setting-to-sc-priority.patch
mm-vmscan-remove-unneeded-return-value-of-kswapd_run.patch
mm-vmscan-add-else-to-remove-check_pending-label.patch
mm-vmscan-fix-misleading-comment-in-isolate_lru_pages.patch
mm-zsmallocc-close-race-window-between-zs_pool_dec_isolated-and-zs_unregister_migration.patch
mm-zsmallocc-combine-two-atomic-ops-in-zs_pool_dec_isolated.patch
