The patch titled
Subject: mm: compaction: remove duplicate !list_empty(&sublist) check
has been added to the -mm tree. Its filename is
mm-compaction-remove-duplicate-list_emptysublist-check.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-remove-duplicate-list_emptysublist-check.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-compaction-remove-duplicate-list_emptysublist-check.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Liu Xiang <liu.xiang@xxxxxxxxxxxxxx>
Subject: mm: compaction: remove duplicate !list_empty(&sublist) check
The list_splice_tail(&sublist, freelist) also do !list_empty(&sublist)
check, so remove the duplicate call.
Link: https://lkml.kernel.org/r/20210609095409.19920-1-liu.xiang@xxxxxxxxxxxxxx
Signed-off-by: Liu Xiang <liu.xiang@xxxxxxxxxxxxxx>
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/compaction.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/mm/compaction.c~mm-compaction-remove-duplicate-list_emptysublist-check
+++ a/mm/compaction.c
@@ -1297,8 +1297,7 @@ move_freelist_head(struct list_head *fre
if (!list_is_last(freelist, &freepage->lru)) {
list_cut_before(&sublist, freelist, &freepage->lru);
- if (!list_empty(&sublist))
- list_splice_tail(&sublist, freelist);
+ list_splice_tail(&sublist, freelist);
}
}
@@ -1315,8 +1314,7 @@ move_freelist_tail(struct list_head *fre
if (!list_is_first(freelist, &freepage->lru)) {
list_cut_position(&sublist, freelist, &freepage->lru);
- if (!list_empty(&sublist))
- list_splice_tail(&sublist, freelist);
+ list_splice_tail(&sublist, freelist);
}
}
_
Patches currently in -mm which might be from liu.xiang@xxxxxxxxxxxxxx are
mm-memoryc-fix-comment-of-finish_mkwrite_fault.patch
mm-compaction-remove-duplicate-list_emptysublist-check.patch
