Re: + mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/15/21 3:39 AM, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
The patch titled
      Subject: mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
has been added to the -mm tree.  Its filename is
      mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch

This patch should soon appear at
     https://ozlabs.org/~akpm/mmots/broken-out/mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch
and later at
     https://ozlabs.org/~akpm/mmotm/broken-out/mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch

Before you just go and hit "reply", please:
    a) Consider who else should be cc'ed
    b) Prefer to cc a suitable mailing list as well
    c) Ideally: find the original patch on the mailing list and do a
       reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix

fix build

Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxx>
Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
Cc: Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>
Cc: Kalesh Singh <kaleshsingh@xxxxxxxxxx>
Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

  mm/mremap.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/mremap.c~mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
+++ a/mm/mremap.c
@@ -216,7 +216,7 @@ static inline void flush_pte_tlb_pwc_ran
  					   unsigned long start,
  					   unsigned long end)
  {
-	return flush_tlb_range(vma, start, end);
+	flush_tlb_range(vma, start, end);
  }
  #endif
_


Thanks for catching this. This is required because on some architectures, flush_tlb_range have non void returns. For example on parisc we have

int __flush_tlb_range(unsigned long sid,
	unsigned long start, unsigned long end);

#define flush_tlb_range(vma, start, end) \
	__flush_tlb_range((vma)->vm_mm->context, start, end)



-aneesh



[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux