The patch titled
Subject: buildid: fix build when CONFIG_MODULES is not set
has been added to the -mm tree. Its filename is
module-add-printk-formats-to-add-module-build-id-to-stacktraces-fix-2.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/module-add-printk-formats-to-add-module-build-id-to-stacktraces-fix-2.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/module-add-printk-formats-to-add-module-build-id-to-stacktraces-fix-2.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Subject: buildid: fix build when CONFIG_MODULES is not set
Omit the static_assert() when CONFIG_MODULES is not set/enabled.
Fixes these build errors:
../kernel/kallsyms.c: In function `__sprint_symbol':
../include/linux/kernel.h:53:43: error: dereferencing pointer to incomplete type `struct module'
#define typeof_member(T, m) typeof(((T*)0)->m)
^
../include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(typeof_member(struct module, build_id)) == 20"
#define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
^
../kernel/kallsyms.c:454:4: note: in expansion of macro `static_assert'
static_assert(sizeof(typeof_member(struct module, build_id)) == 20);
^~~~~~~~~~~~~
Link: https://lkml.kernel.org/r/20210513171510.20328-1-rdunlap@xxxxxxxxxxxxx
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/kallsyms.c | 2 ++
1 file changed, 2 insertions(+)
--- a/kernel/kallsyms.c~module-add-printk-formats-to-add-module-build-id-to-stacktraces-fix-2
+++ a/kernel/kallsyms.c
@@ -451,7 +451,9 @@ static int __sprint_symbol(char *buffer,
#if IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID)
if (add_buildid && buildid) {
/* build ID should match length of sprintf */
+#if IS_ENABLED(CONFIG_MODULES)
static_assert(sizeof(typeof_member(struct module, build_id)) == 20);
+#endif
len += sprintf(buffer + len, " %20phN", buildid);
}
#endif
_
Patches currently in -mm which might be from rdunlap@xxxxxxxxxxxxx are
ia64-headers-drop-duplicated-words.patch
mm-slub-use-stackdepot-to-save-stack-trace-in-objects-fix.patch
module-add-printk-formats-to-add-module-build-id-to-stacktraces-fix-2.patch
