The patch titled
Subject: mm-gup-pack-has_pinned-in-mmf_has_pinned-checkpatch-fixes
has been added to the -mm tree. Its filename is
mm-gup-pack-has_pinned-in-mmf_has_pinned-checkpatch-fixes.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-gup-pack-has_pinned-in-mmf_has_pinned-checkpatch-fixes.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-gup-pack-has_pinned-in-mmf_has_pinned-checkpatch-fixes.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: mm-gup-pack-has_pinned-in-mmf_has_pinned-checkpatch-fixes
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25:
[peterx@xxxxxxxxxx: fix build for task_mmu.c, introduce mm_set_has_pinned_flag, fix comments]
WARNING: please, no spaces at the start of a line
#130: FILE: mm/gup.c:1280:
+ if (!test_bit(MMF_HAS_PINNED, mm_flags))$
WARNING: suspect code indent for conditional statements (7, 15)
#130: FILE: mm/gup.c:1280:
+ if (!test_bit(MMF_HAS_PINNED, mm_flags))
+ set_bit(MMF_HAS_PINNED, mm_flags);
ERROR: code indent should use tabs where possible
#131: FILE: mm/gup.c:1281:
+ set_bit(MMF_HAS_PINNED, mm_flags);$
WARNING: please, no spaces at the start of a line
#131: FILE: mm/gup.c:1281:
+ set_bit(MMF_HAS_PINNED, mm_flags);$
total: 1 errors, 4 warnings, 90 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
./patches/mm-gup-pack-has_pinned-in-mmf_has_pinned.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Peter Xu <peterx@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/gup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/mm/gup.c~mm-gup-pack-has_pinned-in-mmf_has_pinned-checkpatch-fixes
+++ a/mm/gup.c
@@ -1277,8 +1277,8 @@ EXPORT_SYMBOL_GPL(fixup_user_fault);
*/
static inline void mm_set_has_pinned_flag(unsigned long *mm_flags)
{
- if (!test_bit(MMF_HAS_PINNED, mm_flags))
- set_bit(MMF_HAS_PINNED, mm_flags);
+ if (!test_bit(MMF_HAS_PINNED, mm_flags))
+ set_bit(MMF_HAS_PINNED, mm_flags);
}
/*
_
Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
mm.patch
mm-gup-pack-has_pinned-in-mmf_has_pinned-checkpatch-fixes.patch
linux-next-git-rejects.patch
kernel-forkc-export-kernel_thread-to-modules.patch
