On Fri, Mar 19, 2021 at 04:18:14PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> proc-fix-incorrect-pde_is_permanent-check.patch
> Currently the pde_is_permanent() check is being run on root multiple times
> rather than on the next proc directory entry. This looks like a
> copy-paste error. Fix this by replacing root with next.
>
> Addresses-Coverity: ("Copy-paste error")
> Link: https://lkml.kernel.org/r/20210318122633.14222-1-colin.king@xxxxxxxxxxxxx
> Fixes: d919b33dafb3 ("proc: faster open/read/close with "permanent" files")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Acked-by: Christian Brauner <christian.brauner@xxxxxxxxxx>
Doesn't hurt to check more entries.
Reviewed-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> - if (unlikely(pde_is_permanent(root))) {
> + if (unlikely(pde_is_permanent(next))) {
