The patch titled
arch/i386/kernel/io_apic.c: handle a negative return value
has been added to the -mm tree. Its filename is
arch-i386-kernel-io_apicc-handle-a-negative-return-value.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: arch/i386/kernel/io_apic.c: handle a negative return value
From: Adrian Bunk <bunk@xxxxxxxxx>
The Coverity checker noted that bad things might happen if
find_isa_irq_apic() returned -1.
Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
Cc: Andi Kleen <ak@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
arch/i386/kernel/io_apic.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletion(-)
diff -puN arch/i386/kernel/io_apic.c~arch-i386-kernel-io_apicc-handle-a-negative-return-value arch/i386/kernel/io_apic.c
--- a/arch/i386/kernel/io_apic.c~arch-i386-kernel-io_apicc-handle-a-negative-return-value
+++ a/arch/i386/kernel/io_apic.c
@@ -2166,9 +2166,15 @@ static inline void unlock_ExtINT_logic(v
unsigned char save_control, save_freq_select;
pin = find_isa_irq_pin(8, mp_INT);
+ if (pin == -1) {
+ WARN_ON_ONCE(1);
+ return;
+ }
apic = find_isa_irq_apic(8, mp_INT);
- if (pin == -1)
+ if (apic == -1) {
+ WARN_ON_ONCE(1);
return;
+ }
entry0 = ioapic_read_entry(apic, pin);
clear_IO_APIC_pin(apic, pin);
_
Patches currently in -mm which might be from bunk@xxxxxxxxx are
origin.patch
git-alsa.patch
git-mtd.patch
git-netdev-all.patch
git-pcmcia.patch
drivers-scsi-small-cleanups.patch
drivers-scsi-qla2xxx-make-some-functions-static.patch
drivers-scsi-aic7xxx-aic79xx_corec-make-ahd_match_scb-static.patch
drivers-scsi-advansysc-cleanups.patch
megaraid-fix-warnings-when-config_proc_fs=n.patch
drivers-scsi-dpt_i2oc-remove-dead-code.patch
drivers-scsi-psi240ic-fix-an-array-overrun.patch
arch-i386-kernel-io_apicc-handle-a-negative-return-value.patch
acx1xx-wireless-driver.patch
drivers-edac-make-code-static.patch
ext4_ext_split-remove-dead-code.patch
fs-reiser4-possible-cleanups.patch
reiser4-possible-cleanups-2.patch
slab-cache-shrinker-statistics.patch
debug-shared-irqs-kconfig-fix.patch
i386-enable-4k-stacks-by-default.patch
mutex-subsystem-synchro-test-module.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
