On Wed, 2021-03-17 at 22:54 +0000, Matthew Wilcox wrote: > On Wed, Mar 17, 2021 at 03:15:12PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx > wrote: > > Several architectures already have definition of PMD_ORDER as the > > size of second level page table, so to avoid conflict with these > > definitions use PMD_PAGE_ORDER name and update DAX respectively. > > I thought I NACKed this patch already? I don't think anyone understands why. DAX won't build on several architectures, including parisc, because of this existing symbol clash. > The architectures should be updated to not use PMD_ORDER. PMD_ORDER > is clearly the right name for what is now PMD_PAGE_ORDER. The > architectures should be using PMD_ALLOC_ORDER or some such. Well I had a patch renaming the dax specific one to DAX_PMD_ORDER which you also didn't like. Why don't you just propose the patch you do like because this is a build failure on several architectures currently. I don't really care what colour the bike shed is ... I do care that my builds fail. James
