On Fri, Feb 19, 2021 at 12:04:32PM -0800, Mike Kravetz wrote: > On 2/19/21 11:47 AM, Roman Gushchin wrote: > > On Fri, Feb 19, 2021 at 10:37:17AM -0800, Andrew Morton wrote: > >> > >> The patch titled > >> Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page > >> has been added to the -mm tree. Its filename is > >> mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch > >> > >> This patch should soon appear at > >> https://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch > >> and later at > >> https://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch > >> > >> Before you just go and hit "reply", please: > >> a) Consider who else should be cc'ed > >> b) Prefer to cc a suitable mailing list as well > >> c) Ideally: find the original patch on the mailing list and do a > >> reply-to-all to that, adding suitable additional cc's > >> > >> *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** > >> > >> The -mm tree is included into linux-next and is updated > >> there every 3-4 working days > >> > >> ------------------------------------------------------ > >> From: Chen Wandun <chenwandun@xxxxxxxxxx> > >> Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page > >> > >> If hugetlb_cma is enabled, it will skip boot time allocation when > >> allocating gigantic page, that doesn't means allocation failure, so > >> suppress this warning info. > >> > >> Link: https://lkml.kernel.org/r/20210219123909.13130-1-chenwandun@xxxxxxxxxx > >> Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma") > >> Signed-off-by: Chen Wandun <chenwandun@xxxxxxxxxx> > >> Cc: Roman Gushchin <guro@xxxxxx> > >> Cc: Mike Kravetz <mike.kravetz@xxxxxxxxxx> > >> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > > > Acked-by: Roman Gushchin <guro@xxxxxx> > > > > Thank!s > > > Roman, I was under the impression that this warning provided some value? > > It will only be logged if user asks for both preallocation and cma reservation > on the command line. In this case, we ignore the parameter requesting > preallocation. It seems reasonable that we log a warning if dropping a > user requested parameter. There are two warnings: "HugeTLB: hugetlb_cma is enabled, skip boot time allocation\n" and "HugeTLB: allocating %lu of page size %s failed. Only allocated %lu hugepages.\n" The point of this patch is to skip printing the second one if the first one is printed. It makes sense to me. Thanks!
