The patch titled
Subject: lib/cmdline: remove an unneeded local variable in next_arg()
has been added to the -mm tree. Its filename is
lib-cmdline-remove-an-unneeded-local-variable-in-next_arg.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/lib-cmdline-remove-an-unneeded-local-variable-in-next_arg.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/lib-cmdline-remove-an-unneeded-local-variable-in-next_arg.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Masahiro Yamada <masahiroy@xxxxxxxxxx>
Subject: lib/cmdline: remove an unneeded local variable in next_arg()
The local variable 'next' is unneeded because you can simply advance the
existing pointer 'args'.
Link: https://lkml.kernel.org/r/20210201014707.3828753-1-masahiroy@xxxxxxxxxx
Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/cmdline.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/lib/cmdline.c~lib-cmdline-remove-an-unneeded-local-variable-in-next_arg
+++ a/lib/cmdline.c
@@ -215,7 +215,6 @@ char *next_arg(char *args, char **param,
{
unsigned int i, equals = 0;
int in_quote = 0, quoted = 0;
- char *next;
if (*args == '"') {
args++;
@@ -253,10 +252,10 @@ char *next_arg(char *args, char **param,
if (args[i]) {
args[i] = '\0';
- next = args + i + 1;
+ args += i + 1;
} else
- next = args + i;
+ args += i;
/* Chew up trailing spaces. */
- return skip_spaces(next);
+ return skip_spaces(args);
}
_
Patches currently in -mm which might be from masahiroy@xxxxxxxxxx are
lib-cmdline-remove-an-unneeded-local-variable-in-next_arg.patch
init-versionc-remove-version_linux_version_code-symbol.patch
init-clean-up-early_param_on_off-macro.patch
