The patch titled
Subject: groups: simplify struct group_info allocation
has been added to the -mm tree. Its filename is
groups-simplify-struct-group_info-allocation.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/groups-simplify-struct-group_info-allocation.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/groups-simplify-struct-group_info-allocation.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Hubert Jasudowicz <hubert.jasudowicz@xxxxxxxxx>
Subject: groups: simplify struct group_info allocation
Combine kmalloc and vmalloc into a single call. Use struct_size macro
instead of direct size calculation.
Link: https://lkml.kernel.org/r/ba9ba5beea9a44b7196c41a0d9528abd5f20dd2e.1611620846.git.hubert.jasudowicz@xxxxxxxxx
Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@xxxxxxxxx>
Cc: Gao Xiang <xiang@xxxxxxxxxx>
Cc: Micah Morton <mortonm@xxxxxxxxxxxx>
Cc: Michael Kelley <mikelley@xxxxxxxxxxxxx>
Cc: "Peter Zijlstra (Intel)" <peterz@xxxxxxxxxxxxx>
Cc: Thomas Cedeno <thomascedeno@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/groups.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
--- a/kernel/groups.c~groups-simplify-struct-group_info-allocation
+++ a/kernel/groups.c
@@ -15,12 +15,7 @@
struct group_info *groups_alloc(int gidsetsize)
{
struct group_info *gi;
- unsigned int len;
-
- len = sizeof(struct group_info) + sizeof(kgid_t) * gidsetsize;
- gi = kmalloc(len, GFP_KERNEL_ACCOUNT|__GFP_NOWARN|__GFP_NORETRY);
- if (!gi)
- gi = __vmalloc(len, GFP_KERNEL_ACCOUNT);
+ gi = kvmalloc(struct_size(gi, gid, gidsetsize), GFP_KERNEL_ACCOUNT);
if (!gi)
return NULL;
_
Patches currently in -mm which might be from hubert.jasudowicz@xxxxxxxxx are
groups-use-flexible-array-member-in-struct-group_info.patch
groups-simplify-struct-group_info-allocation.patch
