Re: + kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 04 Jan 2021 13:29:13 -0800 akpm@xxxxxxxxxxxxxxxxxxxx wrote:

> 
> From: Lecopzer Chen <lecopzer@xxxxxxxxx>
> Subject: kasan: fix incorrect arguments passing in kasan_add_zero_shadow
> 
> kasan_remove_zero_shadow() shall use original virtual address, start and
> size, instead of shadow address.
> 
> Link: https://lkml.kernel.org/r/20210103063847.5963-1-lecopzer@xxxxxxxxx
> Fixes: 0207df4fa1a86 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN")
> Signed-off-by: Lecopzer Chen <lecopzer.chen@xxxxxxxxxxxx>
> Cc: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> Cc: Alexander Potapenko <glider@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  mm/kasan/init.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/mm/kasan/init.c~kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow
> +++ a/mm/kasan/init.c
> @@ -485,7 +485,6 @@ int kasan_add_zero_shadow(void *start, u
>  
>  	ret = kasan_populate_early_shadow(shadow_start, shadow_end);
>  	if (ret)
> -		kasan_remove_zero_shadow(shadow_start,
> -					size >> KASAN_SHADOW_SCALE_SHIFT);
> +		kasan_remove_zero_shadow(start, size);
>  	return ret;
>  }

Reviewer input on this one, please?



[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux