Re: [to-be-updated] kasan-fix-memory-leak-of-kasan-quarantine.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2020-12-22 at 11:04 -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> The patch titled
>      Subject: kasan: fix memory leak of kasan quarantine
> has been removed from the -mm tree.  Its filename was
>      kasan-fix-memory-leak-of-kasan-quarantine.patch
> 
> This patch was dropped because an updated version will be merged
> 
> ------------------------------------------------------
> From: Kuan-Ying Lee <Kuan-Ying.Lee@xxxxxxxxxxxx>
> Subject: kasan: fix memory leak of kasan quarantine
> 
> When cpu is going offline, set q->offline as true and interrupt happened. 
> The interrupt may call the quarantine_put.  But quarantine_put do not free
> the the object.  The object will cause memory leak.
> 
> Add qlink_free() to free the object.
> 
> Link: https://lkml.kernel.org/r/1608207487-30537-2-git-send-email-Kuan-Ying.Lee@xxxxxxxxxxxx
> Fixes: 6c82d45c7f03 (kasan: fix object remaining in offline per-cpu quarantine)
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@xxxxxxxxxxxx>
> Cc: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
> Cc: Alexander Potapenko <glider@xxxxxxxxxx>
> Cc: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>    [5.10-]
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  mm/kasan/quarantine.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/mm/kasan/quarantine.c~kasan-fix-memory-leak-of-kasan-quarantine
> +++ a/mm/kasan/quarantine.c
> @@ -194,6 +194,7 @@ bool quarantine_put(struct kmem_cache *c
>  
>  	q = this_cpu_ptr(&cpu_quarantine);
>  	if (q->offline) {
> +		qlink_free(&info->quarantine_link, cache);
>  		local_irq_restore(flags);
>  		return false;
>  	}
> _
> 
> Patches currently in -mm which might be from Kuan-Ying.Lee@xxxxxxxxxxxx are
> 
> 

Hi Andrew,

Sorry to bother.
After recently kasan series merged into mainline, the memory leak
issue has been fixed. We don't need this patch anymore.

This patch state can be changed to obsolete.

Please abandon this patch.

Thanks.





[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux