The patch titled
Subject: mm/wap: don't SetPageWorkingset unconditionally during swapin
has been added to the -mm tree. Its filename is
mm-dont-setpageworkingset-unconditionally-during-swapin.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-dont-setpageworkingset-unconditionally-during-swapin.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-dont-setpageworkingset-unconditionally-during-swapin.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Yu Zhao <yuzhao@xxxxxxxxxx>
Subject: mm/wap: don't SetPageWorkingset unconditionally during swapin
We are capable of SetPageWorkingset based on refault distances after
commit aae466b0052e ("mm/swap: implement workingset detection for
anonymous LRU") This is done by workingset_refault(), which is right above
the unconditional SetPageWorkingset deleted by this patch.
The unconditional SetPageWorkingset miscategorizes pages that are read
ahead or never belonged to the working set (e.g., tmpfs pages accessed by
fd). When those pages are swapped in (after they were swapped out) for
the first time, they skew PSI (when using async swap). When this happens
again, depending on their refault distances, they might skew
workingset_restore_anon counter in addition to PSI because their shadows
say they were part of the working set.
Link: https://lkml.kernel.org/r/20201209012400.1771150-1-yuzhao@xxxxxxxxxx
Signed-off-by: Yu Zhao <yuzhao@xxxxxxxxxx>
Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/swap_state.c | 1 -
1 file changed, 1 deletion(-)
--- a/mm/swap_state.c~mm-dont-setpageworkingset-unconditionally-during-swapin
+++ a/mm/swap_state.c
@@ -537,7 +537,6 @@ struct page *__read_swap_cache_async(swp
workingset_refault(page, shadow);
/* Caller will initiate read into locked page */
- SetPageWorkingset(page);
lru_cache_add(page);
*new_page_allocated = true;
return page;
_
Patches currently in -mm which might be from yuzhao@xxxxxxxxxx are
mm-dont-setpageworkingset-unconditionally-during-swapin.patch
