On Wed, Nov 25, 2020 at 4:16 PM <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > > The patch titled > Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix > has been added to the -mm tree. Its filename is > mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch > > This patch should soon appear at > https://ozlabs.org/~akpm/mmots/broken-out/mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch > and later at > https://ozlabs.org/~akpm/mmotm/broken-out/mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** > > The -mm tree is included into linux-next and is updated > there every 3-4 working days > > ------------------------------------------------------ > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix > > fix page unlocking, per Hugh > > Link: https://lkml.kernel.org/r/CANsGZ6a95WK7+2H4Zyg5FwDxhdJQqR8nKND1Cn6r6e3QxWeW4Q@xxxxxxxxxxxxxx > Cc: Christoph Hellwig <hch@xxxxxx> > Cc: Dave Chinner <dchinner@xxxxxxxxxx> > Cc: Hugh Dickins <hughd@xxxxxxxxxx> > Cc: Jan Kara <jack@xxxxxxx> > Cc: Johannes Weiner <hannes@xxxxxxxxxxx> > Cc: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> > Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx> > Cc: William Kucharski <william.kucharski@xxxxxxxxxx> > Cc: Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > > mm/shmem.c | 3 +++ > 1 file changed, 3 insertions(+) > > --- a/mm/shmem.c~mm-truncateshmem-handle-truncates-that-split-thps-fix-fix > +++ a/mm/shmem.c > @@ -962,7 +962,10 @@ static void shmem_undo_range(struct inod > if (index > end) > end = indices[i] - 1; > } > + } else { > + unlock_page(page); > } > + Thanks for bearing with the gmail, and I can't read this clearly in gmail, but I think I have deceived you into misplacing that: it should end up as if (!unfalloc || !PageUptodate(page)) { blah blah blah } else { unlock_page(page); } > index = indices[i - 1] + 1; > pagevec_remove_exceptionals(&pvec); > pagevec_reinit(&pvec); > _ > > Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are > > kthread_worker-document-cpu-hotplug-handling-fix.patch > mm.patch > mm-prevent-gup_fast-from-racing-with-cow-during-fork-checkpatch-fixes.patch > mm-swap_state-skip-meaningless-swap-cache-readahead-when-ra_infowin-==-0-fix.patch > mm-vmallocc-__vmalloc_area_node-avoid-32-bit-overflow.patch > mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch > mm-vmstat-fix-proc-sys-vm-stat_refresh-generating-false-warnings-fix-2.patch > lib-cmdline_kunit-add-a-new-test-suite-for-cmdline-api-fix.patch > ilog2-improve-ilog2-for-constant-arguments-checkpatch-fixes.patch > lib-test_bitmapc-add-for_each_set_clump-test-cases-checkpatch-fixes.patch > resource-fix-kernel-doc-markups-checkpatch-fixes.patch > linux-next-rejects.patch > linux-next-git-rejects.patch > kernel-forkc-export-kernel_thread-to-modules.patch >
