The patch titled
Subject: coredump: fix core_pattern parse error
has been added to the -mm tree. Its filename is
coredump-fix-core_pattern-parse-error.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/coredump-fix-core_pattern-parse-error.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/coredump-fix-core_pattern-parse-error.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Menglong Dong <dong.menglong@xxxxxxxxxx>
Subject: coredump: fix core_pattern parse error
'format_corename()' will splite 'core_pattern' on spaces when it is in
pipe mode, and take helper_argv[0] as the path to usermode executable.
It works fine in most cases. However, if there is a space between
'|' and '/file/path', such as
'| /usr/lib/systemd/systemd-coredump %P %u %g',
helper_argv[0] will be parsed as '', and users will get a
'Core dump to | disabled'.
It is not friendly to users, as the pattern above was valid previously.
Fix this by ignoring the spaces between '|' and '/file/path'.
Link: https://lkml.kernel.org/r/5fb62870.1c69fb81.8ef5d.af76@xxxxxxxxxxxxx
Fixes: 315c69261dd3 ("coredump: split pipe command whitespace before expanding template")
Signed-off-by: Menglong Dong <dong.menglong@xxxxxxxxxx>
Cc: Paul Wise <pabs3@xxxxxxxxxxxxx>
Cc: Jakub Wilk <jwilk@xxxxxxxxx> [https://bugs.debian.org/924398]
Cc: Neil Horman <nhorman@xxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/coredump.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/fs/coredump.c~coredump-fix-core_pattern-parse-error
+++ a/fs/coredump.c
@@ -229,7 +229,8 @@ static int format_corename(struct core_n
*/
if (ispipe) {
if (isspace(*pat_ptr)) {
- was_space = true;
+ if (cn->used != 0)
+ was_space = true;
pat_ptr++;
continue;
} else if (was_space) {
_
Patches currently in -mm which might be from dong.menglong@xxxxxxxxxx are
coredump-fix-core_pattern-parse-error.patch
