The patch titled
Subject: ide: remove BUG_ON(in_interrupt() || irqs_disabled()) from ide_unregister()
has been added to the -mm tree. Its filename is
ide-remove-bug_onin_interrupt-irqs_disabled-from-ide_unregister.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/ide-remove-bug_onin_interrupt-irqs_disabled-from-ide_unregister.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/ide-remove-bug_onin_interrupt-irqs_disabled-from-ide_unregister.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Subject: ide: remove BUG_ON(in_interrupt() || irqs_disabled()) from ide_unregister()
Both BUG_ON() were introduced in commit
4015c949fb465 ("[PATCH] update ide core")
when ide_unregister() was extended with semaphore based locking. Both
checks won't complain about disabled preemption which is also wrong.
The might_sleep() in today's mutex_lock() will complain about the
missuses.
Remove the BUG_ON() statements.
Link: https://lkml.kernel.org/r/20201120092421.1023428-3-bigeasy@xxxxxxxxxxxxx
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Acked-by: Jens Axboe <axboe@xxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/ide/ide-probe.c | 3 ---
1 file changed, 3 deletions(-)
--- a/drivers/ide/ide-probe.c~ide-remove-bug_onin_interrupt-irqs_disabled-from-ide_unregister
+++ a/drivers/ide/ide-probe.c
@@ -1592,9 +1592,6 @@ EXPORT_SYMBOL_GPL(ide_port_unregister_de
static void ide_unregister(ide_hwif_t *hwif)
{
- BUG_ON(in_interrupt());
- BUG_ON(irqs_disabled());
-
mutex_lock(&ide_cfg_mtx);
if (hwif->present) {
_
Patches currently in -mm which might be from bigeasy@xxxxxxxxxxxxx are
ide-remove-bug_onin_interrupt-irqs_disabled-from-ide_unregister.patch
lib-test_lockup-minimum-fix-to-get-it-compiled-on-preempt_rt.patch
rapidio-remove-unused-rio_get_asm-and-rio_get_device.patch
