On Sat, Nov 14, 2020 at 01:39:47PM -0800, Linus Torvalds wrote: > I've applied this patch, but I have to say that I absolutely detest it. > > This is very fragile, and I think the problem is the nasty interface. I agree, it's nast. > Why don't we have simple wrappers that internally do that "mod", but > actually expose "inc" and "dec" instead, and make it much harder to > have these kinds of problems? We actually need 'add' and 'sub', not 'inc' and 'dec'. Sometimes we inc, but often we need to add. But, yes, 'mod' is a bad name.