The patch titled
Subject: mm: fix readahead_page_batch for retry entries
has been added to the -mm tree. Its filename is
mm-fix-readahead_page_batch-for-retry-entries.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-fix-readahead_page_batch-for-retry-entries.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-fix-readahead_page_batch-for-retry-entries.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: mm: fix readahead_page_batch for retry entries
Both btrfs and fuse have reported faults caused by seeing a retry entry
instead of the page they were looking for. This was caused by a missing
check in the iterator.
Link: https://lkml.kernel.org/r/20201103142852.8543-1-willy@xxxxxxxxxxxxx
Fixes: 042124cc64c3 ("mm: add new readahead_control API")
Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
Reported-by: David Sterba <dsterba@xxxxxxxx>
Reported-by: Wonhyuk Yang <vvghjk1234@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/pagemap.h | 2 ++
1 file changed, 2 insertions(+)
--- a/include/linux/pagemap.h~mm-fix-readahead_page_batch-for-retry-entries
+++ a/include/linux/pagemap.h
@@ -906,6 +906,8 @@ static inline unsigned int __readahead_b
xas_set(&xas, rac->_index);
rcu_read_lock();
xas_for_each(&xas, page, rac->_index + rac->_nr_pages - 1) {
+ if (xas_retry(&xas, page))
+ continue;
VM_BUG_ON_PAGE(!PageLocked(page), page);
VM_BUG_ON_PAGE(PageTail(page), page);
array[i++] = page;
_
Patches currently in -mm which might be from willy@xxxxxxxxxxxxx are
mm-fix-readahead_page_batch-for-retry-entries.patch
