From: Miaohe Lin <linmiaohe@xxxxxxxxxx> Subject: lib/percpu_counter.c: use helper macro abs() Use helper macro abs() to simplify the "x >= t || x <= -t" cmp. Link: https://lkml.kernel.org/r/20200927122746.5964-1-linmiaohe@xxxxxxxxxx Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- lib/percpu_counter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/percpu_counter.c~percpu_counter-use-helper-macro-abs +++ a/lib/percpu_counter.c @@ -85,7 +85,7 @@ void percpu_counter_add_batch(struct per preempt_disable(); count = __this_cpu_read(*fbc->counters) + amount; - if (count >= batch || count <= -batch) { + if (abs(count) >= batch) { unsigned long flags; raw_spin_lock_irqsave(&fbc->lock, flags); fbc->count += count; _
