The patch titled
Subject: checkpatch: fix false positive on empty block comment lines
has been added to the -mm tree. Its filename is
checkpatch-fix-false-positive-on-empty-block-comment-lines.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/checkpatch-fix-false-positive-on-empty-block-comment-lines.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-fix-false-positive-on-empty-block-comment-lines.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>
Subject: checkpatch: fix false positive on empty block comment lines
To avoid false positives in presence of SPDX-License-Identifier in
networking files it is required to increase the leeway for empty block
comment lines by one line.
For example, checking drivers/net/loopback.c which starts with
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* INET An implementation of the TCP/IP protocol suite for the LINUX
rsults in an unnecessary warning
WARNING: networking block comments don't use an empty /* line, use /* Comment...
+/*
+ * INET An implementation of the TCP/IP protocol suite for the LINUX
Link: https://lkml.kernel.org/r/20201006083509.19934-1-l.stelmach@xxxxxxxxxxx
Signed-off-by: Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>
Acked-by: Joe Perches <joe@xxxxxxxxxxx>
Cc: Bartłomiej Żolnierkiewicz <b.zolnierkie@xxxxxxxxxx>
Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/scripts/checkpatch.pl~checkpatch-fix-false-positive-on-empty-block-comment-lines
+++ a/scripts/checkpatch.pl
@@ -3466,7 +3466,7 @@ sub process {
if ($realfile =~ m@^(drivers/net/|net/)@ &&
$prevrawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
$rawline =~ /^\+[ \t]*\*/ &&
- $realline > 2) {
+ $realline > 3) { # Do not warn about the initial copyright comment block after SPDX-License-Identifier
WARN("NETWORKING_BLOCK_COMMENT_STYLE",
"networking block comments don't use an empty /* line, use /* Comment...\n" . $hereprev);
}
_
Patches currently in -mm which might be from l.stelmach@xxxxxxxxxxx are
checkpatch-fix-false-positive-on-empty-block-comment-lines.patch
