The patch titled
Subject: lib/mpi: fix off-by-one check on index "no"
has been added to the -mm tree. Its filename is
lib-mpi-fix-off-by-one-check-on-index-no.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/lib-mpi-fix-off-by-one-check-on-index-no.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/lib-mpi-fix-off-by-one-check-on-index-no.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Subject: lib/mpi: fix off-by-one check on index "no"
There is an off-by-one range check on the upper limit of index "no". Fix
this by changing the > comparison to >=.
Addresses-Coverity: ("Out-of-bounds read")
Link: https://lkml.kernel.org/r/20200929131828.155691-1-colin.king@xxxxxxxxxxxxx
Fixes: a8ea8bdd9df9 ("lib/mpi: Extend the MPI library")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Cc: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>
Cc: David Howells <dhowells@xxxxxxxxxx>
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Cc: Waiman Long <longman@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/mpi/mpiutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/lib/mpi/mpiutil.c~lib-mpi-fix-off-by-one-check-on-index-no
+++ a/lib/mpi/mpiutil.c
@@ -69,7 +69,7 @@ postcore_initcall(mpi_init);
*/
MPI mpi_const(enum gcry_mpi_constants no)
{
- if ((int)no < 0 || no > MPI_NUMBER_OF_CONSTANTS)
+ if ((int)no < 0 || no >= MPI_NUMBER_OF_CONSTANTS)
pr_err("MPI: invalid mpi_const selector %d\n", no);
if (!constants[no])
pr_err("MPI: MPI subsystem not initialized\n");
_
Patches currently in -mm which might be from colin.king@xxxxxxxxxxxxx are
lib-mpi-fix-off-by-one-check-on-index-no.patch
