The patch titled
driver-core-fixes-sysfs_create_link-retval-checks-in-debug
has been added to the -mm tree. Its filename is
driver-core-fixes-sysfs_create_link-retval-checks-in-debug.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: driver-core-fixes-sysfs_create_link-retval-checks-in-debug
From: Andrew Morton <akpm@xxxxxxxx>
Cc: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Cc: Mike Galbraith <efault@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/base/core.c | 28 ++++++++++++++++++++++------
1 file changed, 22 insertions(+), 6 deletions(-)
diff -puN drivers/base/core.c~driver-core-fixes-sysfs_create_link-retval-checks-in-debug drivers/base/core.c
--- a/drivers/base/core.c~driver-core-fixes-sysfs_create_link-retval-checks-in-debug
+++ a/drivers/base/core.c
@@ -24,6 +24,8 @@
#include "base.h"
#include "power/power.h"
+#define DB() printk(KERN_ERR "sysfs failure at %s:%d\n", __FILE__, __LINE__)
+
int (*platform_notify)(struct device * dev) = NULL;
int (*platform_notify_remove)(struct device * dev) = NULL;
@@ -373,30 +375,39 @@ static int device_add_class_symlinks(str
return 0;
error = sysfs_create_link(&dev->kobj, &dev->class->subsys.kset.kobj,
"subsystem");
- if (error)
+ if (error) {
+ DB();
goto out;
+ }
error = sysfs_create_link(&dev->class->subsys.kset.kobj, &dev->kobj,
dev->bus_id);
- if (error)
+ if (error) {
+ DB();
goto out_subsys;
+ }
#ifdef CONFIG_SYSFS_DEPRECATED
if (dev->parent) {
char *class_name;
error = sysfs_create_link(&dev->kobj, &dev->parent->kobj,
"device");
- if (error)
+ if (error) {
+ DB();
goto out_busid;
+ }
class_name = make_class_name(dev->class->name, &dev->kobj);
if (!class_name) {
+ DB();
error = -ENOMEM;
goto out_busid;
}
error = sysfs_create_link(&dev->parent->kobj, &dev->kobj,
class_name);
kfree(class_name);
- if (error)
+ if (error) {
+ DB();
goto out_device;
+ }
}
#endif
return 0;
@@ -574,8 +585,10 @@ int device_add(struct device *dev)
dev->devt_attr = attr;
}
- if ((error = device_add_class_symlinks(dev)))
+ if ((error = device_add_class_symlinks(dev))) {
+ DB();
goto SymlinkError;
+ }
if ((error = device_add_attrs(dev)))
goto AttrsError;
if ((error = device_add_groups(dev)))
@@ -941,6 +954,7 @@ int device_rename(struct device *dev, ch
error = kobject_rename(&dev->kobj, new_name);
if (error) {
+ DB();
strlcpy(dev->bus_id, old_device_name, BUS_ID_SIZE);
goto out;
}
@@ -951,8 +965,10 @@ int device_rename(struct device *dev, ch
if (new_class_name) {
error = sysfs_create_link(&dev->parent->kobj,
&dev->kobj, new_class_name);
- if (error)
+ if (error) {
+ DB();
goto out;
+ }
sysfs_remove_link(&dev->parent->kobj, old_class_name);
}
}
_
Patches currently in -mm which might be from akpm@xxxxxxxx are
origin.patch
md-check-bio-address-after-mapping-through-partitions-tidy.patch
printk-timed-ratelimit.patch
schedule-removal-of-futex_fd.patch
acpi_noirq-section-fix.patch
revert-pci-quirk-for-ibm-dock-ii-cardbus-controllers.patch
revert-generic_file_buffered_write-handle-zero-length-iovec-segments.patch
revert-generic_file_buffered_write-deadlock-on-vectored-write.patch
generic_file_buffered_write-cleanup.patch
mm-fix-pagecache-write-deadlocks.patch
fs-prepare_write-fixes-fuse-fix.patch
fs-prepare_write-fixes-fat-fix.patch
acpi-asus-s3-resume-fix.patch
sony_apci-resume.patch
git-cpufreq.patch
driver-core-fixes-sysfs_create_link-retval-checks-in-debug.patch
nozomi-warning-fixes.patch
nozomi-irq-flags-fixes.patch
git-dvb.patch
git-ia64.patch
git-input-fixup.patch
lifebook-learn-about-tabs.patch
git-libata-all.patch
git-mtd.patch
git-netdev-all.patch
libphy-dont-do-that.patch
git-net-configh-got-removed.patch
update-smc91x-driver-with-arm-versatile-board-info.patch
netxen-build-fix.patch
netxen-more-build-fixes.patch
drivers-net-ns83820c-add-paramter-to-disable-auto.patch
ioat-warning-fix.patch
revert-scsi-ips-soft-lockup-during-reset-initialization.patch
scsi-ips-soft-lockup-during-reset-initialization-2.patch
git-scsi-target-fixup.patch
git-scsi-target-vs-git-block.patch
git-watchdog.patch
revert-x86_64-mm-cpa-clflush.patch
prep-for-paravirt-be-careful-about-touching-bios-warning-fix.patch
prep-for-paravirt-desch-clearer-parameter-names-fix.patch
xfs-rename-uio_read.patch
touchkit-ps-2-touchscreen-driver.patch
get-rid-of-zone_table.patch
new-scheme-to-preempt-swap-token-tidy.patch
balance_pdgat-cleanup.patch
vmalloc-optimization-cleanup-bugfixes-tweak.patch
radix-tree-rcu-lockless-readside.patch
acx1xx-wireless-driver.patch
swsusp-add-resume_offset-command-line-parameter-rev-2.patch
add-include-linux-freezerh-and-move-definitions-from-ueagle-fix.patch
deprecate-smbfs-in-favour-of-cifs.patch
edac-new-opteron-athlon64-memory-controller-driver.patch
kbuild-dont-put-temp-files-in-the-source-tree.patch
lockdep-annotate-nfs-nfsd-in-kernel-sockets-tidy.patch
drivers-add-lcd-support-3-Kconfig-fix.patch
setup_irq-better-mismatch-debugging.patch
probe_kernel_address-needs-to-do-set_fs.patch
slab-use-probe_kernel_address.patch
lockdep-spin_lock_irqsave_nested-fix.patch
lockdep-spin_lock_irqsave_nested-fix-2.patch
aio-use-prepare_to_wait.patch
spi-section-fix.patch
pktcdvd-bio-write-congestion-using-blk_congestion_wait-fix.patch
bug-test-1.patch
fsstack-introduce-fsstack_copy_attrinode_-tidy.patch
log2-implement-a-general-integer-log2-facility-in-the-kernel-fix.patch
log2-implement-a-general-integer-log2-facility-in-the-kernel-vs-git-cryptodev.patch
add-process_session-helper-routine-deprecate-old-field-tidy.patch
add-process_session-helper-routine-deprecate-old-field-fix-warnings.patch
add-process_session-helper-routine-deprecate-old-field-fix-warnings-2.patch
fs-cache-provide-a-filesystem-specific-syncable-page-bit-ext4.patch
fs-cache-make-kafs-use-fs-cache-fix.patch
fs-cache-make-kafs-use-fs-cache-vs-streamline-generic_file_-interfaces-and-filemap.patch
nfs-use-local-caching-12-fix.patch
fs-cache-cachefiles-a-cache-that-backs-onto-a-mounted-filesystem-log2-fix.patch
mxser-session-warning-fix.patch
tty-switch-to-ktermios-and-new-framework-warning-fix.patch
tty-switch-to-ktermios-bluetooth-fix.patch
drivers-isdn-handcrafted-min-max-macro-removal-fix.patch
swap_prefetch-vs-zoned-counters.patch
add-include-linux-freezerh-and-move-definitions-from-prefetch.patch
readahead-sysctl-parameters.patch
make-copy_from_user_inatomic-not-zero-the-tail-on-i386-vs-reiser4.patch
resier4-add-include-linux-freezerh-and-move-definitions-from.patch
make-kmem_cache_destroy-return-void-reiser4.patch
reiser4-hardirq-include-fix.patch
reiser4-run-truncate_inode_pages-in-reiser4_delete_inode.patch
reiser4-get_sb_dev-fix.patch
reiser4-vs-zoned-allocator.patch
hpt3xx-rework-rate-filtering-tidy.patch
statistics-infrastructure-fix-buffer-overflow-in-histogram-with-linear-tidy.patch
gtod-persistent-clock-support-i386.patch
hrtimers-state-tracking.patch
clockevents-drivers-for-i386.patch
gtod-mark-tsc-unusable-for-highres-timers.patch
round_jiffies-infrastructure-fix.patch
kevent-core-files-fix.patch
kevent-core-files-s390-hack.patch
kevent-socket-notifications-fix-2.patch
kevent-socket-notifications-fix-4.patch
kevent-timer-notifications-fix.patch
nr_blockdev_pages-in_interrupt-warning.patch
device-suspend-debug.patch
mutex-subsystem-synchro-test-module-fix.patch
slab-leaks3-default-y.patch
x86-kmap_atomic-debugging.patch
restore-rogue-readahead-printk.patch
put_bh-debug.patch
acpi_format_exception-debug.patch
jmicron-warning-fix.patch
squash-ipc-warnings.patch
squash-udf-warnings.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
