The patch titled
pci: fix __pci_register_driver error handling
has been added to the -mm tree. Its filename is
pci-fix-__pci_register_driver-error-handling.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: pci: fix __pci_register_driver error handling
From: Akinobu Mita <akinobu.mita@xxxxxxxxx>
__pci_register_driver() error path forgot to unwind.
driver_unregister() needs to be called when pci_create_newid_file() failed.
Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/pci/pci-driver.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff -puN drivers/pci/pci-driver.c~pci-fix-__pci_register_driver-error-handling drivers/pci/pci-driver.c
--- a/drivers/pci/pci-driver.c~pci-fix-__pci_register_driver-error-handling
+++ a/drivers/pci/pci-driver.c
@@ -440,9 +440,12 @@ int __pci_register_driver(struct pci_dri
/* register with core */
error = driver_register(&drv->driver);
+ if (error)
+ return error;
- if (!error)
- error = pci_create_newid_file(drv);
+ error = pci_create_newid_file(drv);
+ if (error)
+ driver_unregister(&drv->driver);
return error;
}
_
Patches currently in -mm which might be from akinobu.mita@xxxxxxxxx are
debugfs-check-return-value-correctly.patch
git-mtd.patch
git-pcmcia.patch
pci-fix-__pci_register_driver-error-handling.patch
edac_mc-fix-error-handling.patch
bit-revese-library.patch
crc32-replace-bitreverse-by-bitrev32.patch
video-use-bitrev8.patch
net-use-bitrev8.patch
isdn-hisax-use-bitrev8.patch
atm-ambassador-use-bitrev8.patch
isdn-gigaset-use-bitrev8.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
