The patch titled Subject: mm/hugetlb: add missing annotation for gather_surplus_pages() has been added to the -mm tree. Its filename is mm-hugetlb-add-missing-annotation-for-gather_surplus_pages.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-add-missing-annotation-for-gather_surplus_pages.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-add-missing-annotation-for-gather_surplus_pages.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Jules Irenge <jbi.octave@xxxxxxxxx> Subject: mm/hugetlb: add missing annotation for gather_surplus_pages() Sparse reports a warning at gather_surplus_pages() warning: context imbalance in hugetlb_cow() - unexpected unlock The root cause is the missing annotation at gather_surplus_pages() Add the missing __must_hold(&hugetlb_lock) Link: http://lkml.kernel.org/r/20200214204741.94112-7-jbi.octave@xxxxxxxxx Signed-off-by: Jules Irenge <jbi.octave@xxxxxxxxx> Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/hugetlb.c | 1 + 1 file changed, 1 insertion(+) --- a/mm/hugetlb.c~mm-hugetlb-add-missing-annotation-for-gather_surplus_pages +++ a/mm/hugetlb.c @@ -1910,6 +1910,7 @@ struct page *alloc_huge_page_vma(struct * of size 'delta'. */ static int gather_surplus_pages(struct hstate *h, int delta) + __must_hold(&hugetlb_lock) { struct list_head surplus_list; struct page *page, *tmp; _ Patches currently in -mm which might be from jbi.octave@xxxxxxxxx are ocfs2-add-missing-annotations-for-ocfs2_refcount_cache_lock-and-ocfs2_refcount_cache_unlock.patch mm-memcontrol-add-missing-annotation-for-unlock_page_lru.patch mm-memcontrol-add-missing-annotation-for-lock_page_lru.patch mm-compaction-add-missing-annotation-for-compact_lock_irqsave.patch mm-hugetlb-add-missing-annotation-for-gather_surplus_pages.patch mm-mempolicy-add-missing-annotation-for-queue_pages_pmd.patch mm-slub-add-missing-annotation-for-get_map.patch mm-slub-add-missing-annotation-for-put_map.patch mm-zsmalloc-add-missing-annotation-for-migrate_read_lock.patch mm-zsmalloc-add-missing-annotation-for-migrate_read_unlock.patch mm-zsmalloc-add-missing-annotation-for-pin_tag.patch mm-zsmalloc-add-missing-annotation-for-unpin_tag.patch