The patch titled
session_of_pgrp: kill unnecessary do_each_task_pid(PIDTYPE_PGID)
has been added to the -mm tree. Its filename is
session_of_pgrp-kill-unnecessary-do_each_task_pidpidtype_pgid.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: session_of_pgrp: kill unnecessary do_each_task_pid(PIDTYPE_PGID)
From: Oleg Nesterov <oleg@xxxxxxxxxx>
All members of the process group have the same sid and it can't be == 0.
NOTE: this code (and a similar one in sys_setpgid) was needed because it
was possibe to have ->session == 0. It's not possible any longer since
[PATCH] pidhash: don't use zero pids
Commit: c7c6464117a02b0d54feb4ebeca4db70fa493678
Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
kernel/exit.c | 19 ++++++++-----------
1 files changed, 8 insertions(+), 11 deletions(-)
diff -puN kernel/exit.c~session_of_pgrp-kill-unnecessary-do_each_task_pidpidtype_pgid kernel/exit.c
--- a/kernel/exit.c~session_of_pgrp-kill-unnecessary-do_each_task_pidpidtype_pgid
+++ a/kernel/exit.c
@@ -188,21 +188,18 @@ repeat:
int session_of_pgrp(int pgrp)
{
struct task_struct *p;
- int sid = -1;
+ int sid = 0;
read_lock(&tasklist_lock);
- do_each_task_pid(pgrp, PIDTYPE_PGID, p) {
- if (process_session(p) > 0) {
- sid = process_session(p);
- goto out;
- }
- } while_each_task_pid(pgrp, PIDTYPE_PGID, p);
- p = find_task_by_pid(pgrp);
- if (p)
+
+ p = find_task_by_pid_type(PIDTYPE_PGID, pgrp);
+ if (p == NULL)
+ p = find_task_by_pid(pgrp);
+ if (p != NULL)
sid = process_session(p);
-out:
+
read_unlock(&tasklist_lock);
-
+
return sid;
}
_
Patches currently in -mm which might be from oleg@xxxxxxxxxx are
tty-signal-tty-locking.patch
do_task_stat-dont-take-tty_mutex.patch
do_acct_process-dont-take-tty_mutex.patch
trivial-make-set_special_pids-static.patch
sys_unshare-remove-a-broken-clone_sighand-code.patch
sys_setpgid-eliminate-unnecessary-do_each_task_pidpidtype_pgid.patch
session_of_pgrp-kill-unnecessary-do_each_task_pidpidtype_pgid.patch
pidhash-temporary-debug-checks.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
