The patch titled
Subject: autonuma: Reduce cache footprint when scanning page tables
has been added to the -mm tree. Its filename is
autonuma-reduce-cache-footprint-when-scanning-page-tables.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/autonuma-reduce-cache-footprint-when-scanning-page-tables.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/autonuma-reduce-cache-footprint-when-scanning-page-tables.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Huang Ying <ying.huang@xxxxxxxxx>
Subject: autonuma: Reduce cache footprint when scanning page tables
In auto NUMA balancing page table scanning, if the pte_protnone() is true,
the PTE needs not to be changed because it's in target state already. So
other checking on corresponding struct page is unnecessary too.
So, if we check pte_protnone() firstly for each PTE, we can avoid
unnecessary struct page accessing, so that reduce the cache footprint of
NUMA balancing page table scanning.
In the performance test of pmbench memory accessing benchmark with 80:20
read/write ratio and normal access address distribution on a 2 socket
Intel server with Optance DC Persistent Memory, perf profiling shows that
the autonuma page table scanning time reduces from 1.23% to 0.97% (that
is, reduced 21%) with the patch.
Link: http://lkml.kernel.org/r/20191101075727.26683-3-ying.huang@xxxxxxxxx
Signed-off-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
Acked-by: Mel Gorman <mgorman@xxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxx>
Cc: Rik van Riel <riel@xxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Cc: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/mprotect.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/mm/mprotect.c~autonuma-reduce-cache-footprint-when-scanning-page-tables
+++ a/mm/mprotect.c
@@ -80,6 +80,10 @@ static unsigned long change_pte_range(st
if (prot_numa) {
struct page *page;
+ /* Avoid TLB flush if possible */
+ if (pte_protnone(oldpte))
+ continue;
+
page = vm_normal_page(vma, addr, oldpte);
if (!page || PageKsm(page))
continue;
@@ -97,10 +101,6 @@ static unsigned long change_pte_range(st
if (page_is_file_cache(page) && PageDirty(page))
continue;
- /* Avoid TLB flush if possible */
- if (pte_protnone(oldpte))
- continue;
-
/*
* Don't mess with PTEs if page is already on the node
* a single-threaded process is running on.
_
Patches currently in -mm which might be from ying.huang@xxxxxxxxx are
autonuma-fix-watermark-checking-in-migrate_balanced_pgdat.patch
autonuma-reduce-cache-footprint-when-scanning-page-tables.patch
