The patch titled
Subject: kernel/sys.c: avoid copying possible padding bytes in copy_to_user
has been added to the -mm tree. Its filename is
kernel-sysc-avoid-copying-possible-padding-bytes-in-copy_to_user.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/kernel-sysc-avoid-copying-possible-padding-bytes-in-copy_to_user.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/kernel-sysc-avoid-copying-possible-padding-bytes-in-copy_to_user.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Joe Perches <joe@xxxxxxxxxxx>
Subject: kernel/sys.c: avoid copying possible padding bytes in copy_to_user
Initialization is not guaranteed to zero padding bytes so use an explicit
memset instead to avoid leaking any kernel content in any possible padding
bytes.
Link: http://lkml.kernel.org/r/dfa331c00881d61c8ee51577a082d8bebd61805c.camel@xxxxxxxxxxx
Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
Cc: Dan Carpenter <error27@xxxxxxxxx>
Cc: Julia Lawall <julia.lawall@xxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Kees Cook <keescook@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/sys.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/kernel/sys.c~kernel-sysc-avoid-copying-possible-padding-bytes-in-copy_to_user
+++ a/kernel/sys.c
@@ -1279,11 +1279,13 @@ SYSCALL_DEFINE1(uname, struct old_utsnam
SYSCALL_DEFINE1(olduname, struct oldold_utsname __user *, name)
{
- struct oldold_utsname tmp = {};
+ struct oldold_utsname tmp;
if (!name)
return -EFAULT;
+ memset(&tmp, 0, sizeof(tmp));
+
down_read(&uts_sem);
memcpy(&tmp.sysname, &utsname()->sysname, __OLD_UTS_LEN);
memcpy(&tmp.nodename, &utsname()->nodename, __OLD_UTS_LEN);
_
Patches currently in -mm which might be from joe@xxxxxxxxxxx are
kernel-sysc-avoid-copying-possible-padding-bytes-in-copy_to_user.patch
get_maintainer-add-signatures-from-fixes-badcommit-lines-in-commit-message.patch
string-add-stracpy-and-stracpy_pad-mechanisms.patch
checkpatch-improve-ignoring-camelcase-si-style-variants-like-ma.patch
