The patch titled
sys_setpgid: eliminate unnecessary do_each_task_pid(PIDTYPE_PGID)
has been added to the -mm tree. Its filename is
sys_setpgid-eliminate-unnecessary-do_each_task_pidpidtype_pgid.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: sys_setpgid: eliminate unnecessary do_each_task_pid(PIDTYPE_PGID)
From: Oleg Nesterov <oleg@xxxxxxxxxx>
All tasks in the process group have the same sid, we don't need to iterate
them all to check that the caller of sys_setpgid() doesn't change its
session.
Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
kernel/sys.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff -puN kernel/sys.c~sys_setpgid-eliminate-unnecessary-do_each_task_pidpidtype_pgid kernel/sys.c
--- a/kernel/sys.c~sys_setpgid-eliminate-unnecessary-do_each_task_pidpidtype_pgid
+++ a/kernel/sys.c
@@ -1398,16 +1398,13 @@ asmlinkage long sys_setpgid(pid_t pid, p
goto out;
if (pgid != pid) {
- struct task_struct *p;
+ struct task_struct *g =
+ find_task_by_pid_type(PIDTYPE_PGID, pgid);
- do_each_task_pid(pgid, PIDTYPE_PGID, p) {
- if (process_session(p) == process_session(group_leader))
- goto ok_pgid;
- } while_each_task_pid(pgid, PIDTYPE_PGID, p);
- goto out;
+ if (!g || process_session(g) != process_session(group_leader))
+ goto out;
}
-ok_pgid:
err = security_task_setpgid(p, pgid);
if (err)
goto out;
_
Patches currently in -mm which might be from oleg@xxxxxxxxxx are
tty-signal-tty-locking.patch
do_task_stat-dont-take-tty_mutex.patch
do_acct_process-dont-take-tty_mutex.patch
trivial-make-set_special_pids-static.patch
sys_unshare-remove-a-broken-clone_sighand-code.patch
sys_setpgid-eliminate-unnecessary-do_each_task_pidpidtype_pgid.patch
pidhash-temporary-debug-checks.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
