The patch titled Subject: mm/userfaultfd: fix a GCC compilation warning has been added to the -mm tree. Its filename is hugetlb-remove-unused-hstate-in-hugetlb_fault_mutex_hash-fix-fix.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/hugetlb-remove-unused-hstate-in-hugetlb_fault_mutex_hash-fix-fix.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/hugetlb-remove-unused-hstate-in-hugetlb_fault_mutex_hash-fix-fix.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Qian Cai <cai@xxxxxx> Subject: mm/userfaultfd: fix a GCC compilation warning The linux-next commit "hugetlb-remove-unused-hstate-in-hugetlb_fault_mutex_hash-fix" seems accidentally add back an unused variable that was correctly removed in the commit "hugetlb: remove unused hstate in hugetlb_fault_mutex_hash()" [1]. mm/userfaultfd.c: In function '__mcopy_atomic_hugetlb': mm/userfaultfd.c:217:17: warning: variable 'h' set but not used [-Wunused-but-set-variable] struct hstate *h; ^ [1] http://lkml.kernel.org/r/20191005003302.785-1-richardw.yang@xxxxxxxxxxxxxxx Link: http://lkml.kernel.org/r/1570544108-32331-1-git-send-email-cai@xxxxxx Signed-off-by: Qian Cai <cai@xxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/userfaultfd.c | 3 --- 1 file changed, 3 deletions(-) --- a/mm/userfaultfd.c~hugetlb-remove-unused-hstate-in-hugetlb_fault_mutex_hash-fix-fix +++ a/mm/userfaultfd.c @@ -184,7 +184,6 @@ static __always_inline ssize_t __mcopy_a unsigned long src_addr, dst_addr; long copied; struct page *page; - struct hstate *h; unsigned long vma_hpagesize; pgoff_t idx; u32 hash; @@ -256,8 +255,6 @@ retry: goto out_unlock; } - h = hstate_vma(dst_vma); - while (src_addr < src_start + len) { pte_t dst_pteval; _ Patches currently in -mm which might be from cai@xxxxxx are mm-slub-fix-a-deadlock-in-show_slab_objects.patch hugetlb-remove-unused-hstate-in-hugetlb_fault_mutex_hash-fix-fix.patch