From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Subject: fat: delete an unnecessary check before brelse() brelse() tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Link: http://lkml.kernel.org/r/cfff3b81-fb5d-af26-7b5e-724266509045@xxxxxx Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/fat/dir.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/fs/fat/dir.c~fat-delete-an-unnecessary-check-before-brelse +++ a/fs/fat/dir.c @@ -88,9 +88,7 @@ static int fat__get_entry(struct inode * int err, offset; next: - if (*bh) - brelse(*bh); - + brelse(*bh); *bh = NULL; iblock = *pos >> sb->s_blocksize_bits; err = fat_bmap(dir, iblock, &phys, &mapped_blocks, 0, false); _
