The patch titled
Subject: wimax/i2400m: remove unlikely() from WARN*() condition
has been added to the -mm tree. Its filename is
wimax-i2400m-remove-unlikely-from-warn-condition.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/wimax-i2400m-remove-unlikely-from-warn-condition.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/wimax-i2400m-remove-unlikely-from-warn-condition.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Denis Efremov <efremov@xxxxxxxxx>
Subject: wimax/i2400m: remove unlikely() from WARN*() condition
"unlikely(WARN_ON(x))" is excessive. WARN_ON() already uses unlikely()
internally.
Link: http://lkml.kernel.org/r/20190829165025.15750-6-efremov@xxxxxxxxx
Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@xxxxxxxxx>
Cc: Joe Perches <joe@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/net/wimax/i2400m/tx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/wimax/i2400m/tx.c~wimax-i2400m-remove-unlikely-from-warn-condition
+++ a/drivers/net/wimax/i2400m/tx.c
@@ -654,8 +654,7 @@ void i2400m_tx_close(struct i2400m *i240
padding = aligned_size - tx_msg_moved->size;
if (padding > 0) {
pad_buf = i2400m_tx_fifo_push(i2400m, padding, 0, 0);
- if (unlikely(WARN_ON(pad_buf == NULL
- || pad_buf == TAIL_FULL))) {
+ if (WARN_ON(pad_buf == NULL || pad_buf == TAIL_FULL)) {
/* This should not happen -- append should verify
* there is always space left at least to append
* tx_block_size */
_
Patches currently in -mm which might be from efremov@xxxxxxxxx are
checkpatch-check-for-nested-unlikely-calls.patch
drm-msm-remove-unlikely-from-warn_on-conditions.patch
net-mlx5e-remove-unlikely-from-warn-condition.patch
xen-events-remove-unlikely-from-warn-condition.patch
fs-remove-unlikely-from-warn_on-condition.patch
wimax-i2400m-remove-unlikely-from-warn-condition.patch
xfs-remove-unlikely-from-warn_on-condition.patch
ib-hfi1-remove-unlikely-from-is_err-condition.patch
udp-remove-unlikely-from-is_err-condition.patch
ntfs-remove-unlikely-from-is_err-conditions.patch
