The patch titled
Subject: net/mlx5e: remove unlikely() from WARN*() condition
has been added to the -mm tree. Its filename is
net-mlx5e-remove-unlikely-from-warn-condition.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/net-mlx5e-remove-unlikely-from-warn-condition.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/net-mlx5e-remove-unlikely-from-warn-condition.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Denis Efremov <efremov@xxxxxxxxx>
Subject: net/mlx5e: remove unlikely() from WARN*() condition
"unlikely(WARN_ON_ONCE(x))" is excessive. WARN_ON_ONCE() already uses
unlikely() internally.
Link: http://lkml.kernel.org/r/20190829165025.15750-3-efremov@xxxxxxxxx
Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>
Acked-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx>
Cc: Boris Pismenny <borisp@xxxxxxxxxxxx>
Cc: Leon Romanovsky <leon@xxxxxxxxxx>
Cc: Joe Perches <joe@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c~net-mlx5e-remove-unlikely-from-warn-condition
+++ a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c
@@ -408,7 +408,7 @@ struct sk_buff *mlx5e_ktls_handle_tx_skb
goto out;
tls_ctx = tls_get_ctx(skb->sk);
- if (unlikely(WARN_ON_ONCE(tls_ctx->netdev != netdev)))
+ if (WARN_ON_ONCE(tls_ctx->netdev != netdev))
goto err_out;
priv_tx = mlx5e_get_ktls_tx_priv_ctx(tls_ctx);
_
Patches currently in -mm which might be from efremov@xxxxxxxxx are
checkpatch-check-for-nested-unlikely-calls.patch
drm-msm-remove-unlikely-from-warn_on-conditions.patch
net-mlx5e-remove-unlikely-from-warn-condition.patch
xen-events-remove-unlikely-from-warn-condition.patch
fs-remove-unlikely-from-warn_on-condition.patch
wimax-i2400m-remove-unlikely-from-warn-condition.patch
xfs-remove-unlikely-from-warn_on-condition.patch
ib-hfi1-remove-unlikely-from-is_err-condition.patch
udp-remove-unlikely-from-is_err-condition.patch
ntfs-remove-unlikely-from-is_err-conditions.patch
