The patch titled
Subject: kernel/elfcore.c: include proper prototypes
has been added to the -mm tree. Its filename is
include-proper-prototypes-for-kernel-elfcorec.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/include-proper-prototypes-for-kernel-elfcorec.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/include-proper-prototypes-for-kernel-elfcorec.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Valdis Kletnieks <valdis.kletnieks@xxxxxx>
Subject: kernel/elfcore.c: include proper prototypes
When building with W=1, gcc properly complains that there's no prototypes:
CC kernel/elfcore.o
kernel/elfcore.c:7:17: warning: no previous prototype for 'elf_core_extra_phdrs' [-Wmissing-prototypes]
7 | Elf_Half __weak elf_core_extra_phdrs(void)
| ^~~~~~~~~~~~~~~~~~~~
kernel/elfcore.c:12:12: warning: no previous prototype for 'elf_core_write_extra_phdrs' [-Wmissing-prototypes]
12 | int __weak elf_core_write_extra_phdrs(struct coredump_params *cprm, loff_t offset)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/elfcore.c:17:12: warning: no previous prototype for 'elf_core_write_extra_data' [-Wmissing-prototypes]
17 | int __weak elf_core_write_extra_data(struct coredump_params *cprm)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
kernel/elfcore.c:22:15: warning: no previous prototype for 'elf_core_extra_data_size' [-Wmissing-prototypes]
22 | size_t __weak elf_core_extra_data_size(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~
Provide the include file so gcc is happy, and we don't have potential code drift
Link: http://lkml.kernel.org/r/29875.1565224705@turing-police
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/elfcore.c | 1 +
1 file changed, 1 insertion(+)
--- a/kernel/elfcore.c~include-proper-prototypes-for-kernel-elfcorec
+++ a/kernel/elfcore.c
@@ -3,6 +3,7 @@
#include <linux/fs.h>
#include <linux/mm.h>
#include <linux/binfmts.h>
+#include <linux/elfcore.h>
Elf_Half __weak elf_core_extra_phdrs(void)
{
_
Patches currently in -mm which might be from valdis.kletnieks@xxxxxx are
include-proper-prototypes-for-kernel-elfcorec.patch
lib-generic-radix-treec-make-2-functions-static-inline.patch
lib-extablec-add-missing-prototypes.patch
