The patch titled
Subject: ocfs2: ensure ret is set to zero before returning
has been added to the -mm tree. Its filename is
ocfs-further-debugfs-cleanups-fix.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/ocfs-further-debugfs-cleanups-fix.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/ocfs-further-debugfs-cleanups-fix.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Subject: ocfs2: ensure ret is set to zero before returning
A previous commit introduced a regression where variable ret was
originally being set from the return from a call to function
dlm_create_debugfs_subroot and this set was removed. Currently ret is now
uninitialized if no alloction errors are found which may end up with a
bogus check on ret < 0 on the 'leave:' return path. Fix this by setting
ret to zero on a successful execution path.
Addresses Coverity: ("Uninitialzed scalar variable")
Link: http://lkml.kernel.org/r/20190807121929.28918-1-colin.king@xxxxxxxxxxxxx
Fixes: cba322160ef0 ("ocfs2: further debugfs cleanups")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Reviewed-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>
Cc: Mark Fasheh <mark@xxxxxxxxxx>
Cc: Joel Becker <jlbec@xxxxxxxxxxxx>
Cc: Jia Guo <guojia12@xxxxxxxxxx>
Cc: Junxiao Bi <junxiao.bi@xxxxxxxxxx>
Cc: Changwei Ge <gechangwei@xxxxxxx>
Cc: Gang He <ghe@xxxxxxxx>
Cc: Jun Piao <piaojun@xxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/ocfs2/dlm/dlmdomain.c | 1 +
1 file changed, 1 insertion(+)
--- a/fs/ocfs2/dlm/dlmdomain.c~ocfs-further-debugfs-cleanups-fix
+++ a/fs/ocfs2/dlm/dlmdomain.c
@@ -2052,6 +2052,7 @@ static struct dlm_ctxt *dlm_alloc_ctxt(c
mlog(0, "context init: refcount %u\n",
kref_read(&dlm->dlm_refs));
+ ret = 0;
leave:
if (ret < 0 && dlm) {
if (dlm->master_hash)
_
Patches currently in -mm which might be from colin.king@xxxxxxxxxxxxx are
ocfs-further-debugfs-cleanups-fix.patch
