The patch titled
Subject: rbtree-avoid-generating-code-twice-for-the-cached-versions-checkpatch-fixes
has been removed from the -mm tree. Its filename was
rbtree-avoid-generating-code-twice-for-the-cached-versions-checkpatch-fixes.patch
This patch was dropped because it was folded into rbtree-avoid-generating-code-twice-for-the-cached-versions.patch
------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: rbtree-avoid-generating-code-twice-for-the-cached-versions-checkpatch-fixes
WARNING: 'implemntation' may be misspelled - perhaps 'implementation'?
#8:
rb_leftmost was wired deeper into the implemntation, but there were some
ERROR: Macros with complex values should be enclosed in parentheses
#180: FILE: include/linux/rbtree.h:130:
+#define RB_ROOT_CACHED (struct rb_root_cached) { {NULL, }, NULL }
ERROR: Macros with complex values should be enclosed in parentheses
#183: FILE: include/linux/rbtree.h:133:
+#define rb_first_cached(root) (root)->rb_leftmost
ERROR: code indent should use tabs where possible
#197: FILE: include/linux/rbtree.h:147:
+ if (root->rb_leftmost == node)$
WARNING: please, no spaces at the start of a line
#197: FILE: include/linux/rbtree.h:147:
+ if (root->rb_leftmost == node)$
ERROR: code indent should use tabs where possible
#198: FILE: include/linux/rbtree.h:148:
+ root->rb_leftmost = rb_next(node);$
WARNING: please, no spaces at the start of a line
#198: FILE: include/linux/rbtree.h:148:
+ root->rb_leftmost = rb_next(node);$
total: 4 errors, 3 warnings, 246 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
./patches/rbtree-avoid-generating-code-twice-for-the-cached-versions.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Michel Lespinasse <walken@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/rbtree.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/include/linux/rbtree.h~rbtree-avoid-generating-code-twice-for-the-cached-versions-checkpatch-fixes
+++ a/include/linux/rbtree.h
@@ -144,8 +144,8 @@ static inline void rb_insert_color_cache
static inline void rb_erase_cached(struct rb_node *node,
struct rb_root_cached *root)
{
- if (root->rb_leftmost == node)
- root->rb_leftmost = rb_next(node);
+ if (root->rb_leftmost == node)
+ root->rb_leftmost = rb_next(node);
rb_erase(node, &root->rb_root);
}
_
Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
mm-vmscanc-add-checks-for-incorrect-handling-of-current-reclaim_state.patch
rbtree-avoid-generating-code-twice-for-the-cached-versions.patch
coda-add-hinting-support-for-partial-file-caching-fix.patch
selftests-ptrace-add-a-test-case-for-ptrace_get_syscall_info-checkpatch-fixes.patch
