The patch titled
uml: mmapper - remove just added but wrong "const" attribute
has been removed from the -mm tree. Its filename was
uml-mmapper-remove-just-added-but-wrong-const-attribute.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
Subject: uml: mmapper - remove just added but wrong "const" attribute
From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>
When enabling the mmapper driver I got warnings because this "const"
miscdevice structure is passed to function as non-const pointer; unlike struct
tty_operations, however, I verified that misc_{de,}register _do_ modify their
parameter, so this const attribute must be removed.
Since the purpose of the change was to guarantee that no lock was needed, add
a comment to prove this differently.
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>
Cc: Jeff Dike <jdike@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
arch/um/drivers/mmapper_kern.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN arch/um/drivers/mmapper_kern.c~uml-mmapper-remove-just-added-but-wrong-const-attribute arch/um/drivers/mmapper_kern.c
--- a/arch/um/drivers/mmapper_kern.c~uml-mmapper-remove-just-added-but-wrong-const-attribute
+++ a/arch/um/drivers/mmapper_kern.c
@@ -95,7 +95,8 @@ static const struct file_operations mmap
.release = mmapper_release,
};
-static const struct miscdevice mmapper_dev = {
+/* No locking needed - only used (and modified) by below initcall and exitcall. */
+static struct miscdevice mmapper_dev = {
.minor = MISC_DYNAMIC_MINOR,
.name = "mmapper",
.fops = &mmapper_fops
_
Patches currently in -mm which might be from blaisorblade@xxxxxxxx are
origin.patch
uml-fix-prototypes.patch
uml-make-execvp-safe-for-our-usage.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
