The patch titled
Subject: fs/reiserfs/journal.c: change return type of dirty_one_transaction
has been added to the -mm tree. Its filename is
fs-reiserfs-journal-change-return-type-of-dirty_one_transaction.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/fs-reiserfs-journal-change-return-type-of-dirty_one_transaction.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/fs-reiserfs-journal-change-return-type-of-dirty_one_transaction.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx>
Subject: fs/reiserfs/journal.c: change return type of dirty_one_transaction
Change return type of dirty_one_transaction from int to void. As this
function always return success.
Fixes below issue reported by coccicheck:
fs/reiserfs/journal.c:1690:5-8: Unneeded variable: "ret". Return "0" on line 1719
Link: http://lkml.kernel.org/r/20190702175430.GA5882@hari-Inspiron-1545
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx>
Cc: Jan Kara <jack@xxxxxxx>
Cc: Arnd Bergmann <arnd@xxxxxxxx>
Cc: Bharath Vedartham <linux.bhar@xxxxxxxxx>
Cc: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/reiserfs/journal.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/fs/reiserfs/journal.c~fs-reiserfs-journal-change-return-type-of-dirty_one_transaction
+++ a/fs/reiserfs/journal.c
@@ -94,7 +94,7 @@ static int journal_join(struct reiserfs_
struct super_block *sb);
static void release_journal_dev(struct super_block *super,
struct reiserfs_journal *journal);
-static int dirty_one_transaction(struct super_block *s,
+static void dirty_one_transaction(struct super_block *s,
struct reiserfs_journal_list *jl);
static void flush_async_commits(struct work_struct *work);
static void queue_log_writer(struct super_block *s);
@@ -1682,12 +1682,11 @@ next:
}
/* used by flush_commit_list */
-static int dirty_one_transaction(struct super_block *s,
+static void dirty_one_transaction(struct super_block *s,
struct reiserfs_journal_list *jl)
{
struct reiserfs_journal_cnode *cn;
struct reiserfs_journal_list *pjl;
- int ret = 0;
jl->j_state |= LIST_DIRTY;
cn = jl->j_realblock;
@@ -1716,7 +1715,6 @@ static int dirty_one_transaction(struct
}
cn = cn->next;
}
- return ret;
}
static int kupdate_transactions(struct super_block *s,
_
Patches currently in -mm which might be from hariprasad.kelam@xxxxxxxxx are
fs-reiserfs-journal-change-return-type-of-dirty_one_transaction.patch
