The patch titled
Subject: slub: don't panic for memcg kmem cache creation failure
has been added to the -mm tree. Its filename is
slub-dont-panic-for-memcg-kmem-cache-creation-failure.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/slub-dont-panic-for-memcg-kmem-cache-creation-failure.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/slub-dont-panic-for-memcg-kmem-cache-creation-failure.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Shakeel Butt <shakeelb@xxxxxxxxxx>
Subject: slub: don't panic for memcg kmem cache creation failure
Currently for CONFIG_SLUB, if a memcg kmem cache creation is failed and
the corresponding root kmem cache has SLAB_PANIC flag, the kernel will be
crashed. This is unnecessary as the kernel can handle the creation
failures of memcg kmem caches. Additionally CONFIG_SLAB does not
implement this behavior. So, to keep the behavior consistent between SLAB
and SLUB, removing the panic for memcg kmem cache creation failures. The
root kmem cache creation failure for SLAB_PANIC correctly panics for both
SLAB and SLUB.
Link: http://lkml.kernel.org/r/20190619232514.58994-1-shakeelb@xxxxxxxxxx
Reported-by: Dave Hansen <dave.hansen@xxxxxxxxx>
Signed-off-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Cc: Christoph Lameter <cl@xxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxx>
Cc: Roman Gushchin <guro@xxxxxx>
Cc: Pekka Enberg <penberg@xxxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/slub.c | 4 ----
1 file changed, 4 deletions(-)
--- a/mm/slub.c~slub-dont-panic-for-memcg-kmem-cache-creation-failure
+++ a/mm/slub.c
@@ -3650,10 +3650,6 @@ static int kmem_cache_open(struct kmem_c
free_kmem_cache_nodes(s);
error:
- if (flags & SLAB_PANIC)
- panic("Cannot create slab %s size=%u realsize=%u order=%u offset=%u flags=%lx\n",
- s->name, s->size, s->size,
- oo_order(s->oo), s->offset, (unsigned long)flags);
return -EINVAL;
}
_
Patches currently in -mm which might be from shakeelb@xxxxxxxxxx are
slub-dont-panic-for-memcg-kmem-cache-creation-failure.patch
memcg-oom-no-oom-kill-for-__gfp_retry_mayfail.patch
memcg-fsnotify-no-oom-kill-for-remote-memcg-charging.patch
mm-memcg-introduce-memoryeventslocal.patch
mm-oom-refactor-dump_tasks-for-memcg-ooms.patch
mm-oom-fix-oom_unkillable_task-for-memcg-ooms.patch
