The patch titled NFS: remove unused check in nfs4_open_revalidate has been added to the -mm tree. Its filename is nfs-remove-unused-check-in-nfs4_open_revalidate.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: NFS: remove unused check in nfs4_open_revalidate From: Chuck Lever <chuck.lever@xxxxxxxxxx> Coverity spotted a superfluous error check in nfs4_open_revalidate(). Remove it. Coverity: #cid 847 Test plan: Code inspection; another pass through Coverity. Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- fs/nfs/nfs4proc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff -puN fs/nfs/nfs4proc.c~nfs-remove-unused-check-in-nfs4_open_revalidate fs/nfs/nfs4proc.c --- a/fs/nfs/nfs4proc.c~nfs-remove-unused-check-in-nfs4_open_revalidate +++ a/fs/nfs/nfs4proc.c @@ -1314,11 +1314,9 @@ nfs4_open_revalidate(struct inode *dir, case -EROFS: lookup_instantiate_filp(nd, (struct dentry *)state, NULL); return 1; - case -ENOENT: - if (dentry->d_inode == NULL) - return 1; + default: + goto out_drop; } - goto out_drop; } if (state->inode == dentry->d_inode) { nfs4_intent_set_file(nd, dentry, state); _ Patches currently in -mm which might be from chuck.lever@xxxxxxxxxx are origin.patch nfs-fix-minor-bug-in-new-nfs-symlink-code.patch nfs-__nfs_revalidate_inode-can-use-inode-before.patch nfs-remove-unused-check-in-nfs4_open_revalidate.patch sunrpc-fix-race-in-in-kernel-rpc-portmapper-client.patch sunrpc-fix-a-typo.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html