+ mtd-rawnand-vf610_nfc-add-initializer-to-avoid-wmaybe-uninitialized.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: mtd: rawnand: vf610_nfc: add initializer to avoid -Wmaybe-uninitialized
has been added to the -mm tree.  Its filename is
     mtd-rawnand-vf610_nfc-add-initializer-to-avoid-wmaybe-uninitialized.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/mtd-rawnand-vf610_nfc-add-initializer-to-avoid-wmaybe-uninitialized.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/mtd-rawnand-vf610_nfc-add-initializer-to-avoid-wmaybe-uninitialized.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Subject: mtd: rawnand: vf610_nfc: add initializer to avoid -Wmaybe-uninitialized

This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place.
We need to eliminate potential issues beforehand.

Kbuild test robot has never reported -Wmaybe-uninitialized warning for
this probably because vf610_nfc_run() is inlined by the x86 compiler's
inlining heuristic.

If CONFIG_OPTIMIZE_INLINING is enabled for a different architecture and
vf610_nfc_run() is not inlined, the following warning is reported:

drivers/mtd/nand/raw/vf610_nfc.c: In function `vf610_nfc_cmd':
drivers/mtd/nand/raw/vf610_nfc.c:455:3: warning: `offset' may be used uninitialized in this function [-Wmaybe-uninitialized]
   vf610_nfc_rd_from_sram(instr->ctx.data.buf.in + offset,
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            nfc->regs + NFC_MAIN_AREA(0) + offset,
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            trfr_sz, !nfc->data_access);
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~

Link: http://lkml.kernel.org/r/20190423034959.13525-6-yamada.masahiro@xxxxxxxxxxxxx
Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/mtd/nand/raw/vf610_nfc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/mtd/nand/raw/vf610_nfc.c~mtd-rawnand-vf610_nfc-add-initializer-to-avoid-wmaybe-uninitialized
+++ a/drivers/mtd/nand/raw/vf610_nfc.c
@@ -364,7 +364,7 @@ static int vf610_nfc_cmd(struct nand_chi
 {
 	const struct nand_op_instr *instr;
 	struct vf610_nfc *nfc = chip_to_nfc(chip);
-	int op_id = -1, trfr_sz = 0, offset;
+	int op_id = -1, trfr_sz = 0, offset = 0;
 	u32 col = 0, row = 0, cmd1 = 0, cmd2 = 0, code = 0;
 	bool force8bit = false;
 
_

Patches currently in -mm which might be from yamada.masahiro@xxxxxxxxxxxxx are

remove-spdx-with-linux-syscall-note-from-kernel-space-headers.patch
arm64-mark-__cpus_have_const_cap-as-__always_inline.patch
mips-mark-mult_sh_align_mod-as-__always_inline.patch
s390-cpacf-mark-scpacf_query-as-__always_inline.patch
mtd-rawnand-vf610_nfc-add-initializer-to-avoid-wmaybe-uninitialized.patch
mips-mark-__fls-and-__ffs-as-__always_inline.patch
arm-mark-setup_machine_tags-stub-as-__init-__noreturn.patch
powerpc-prom_init-mark-prom_getprop-and-prom_getproplen-as-__init.patch
powerpc-mm-radix-mark-__radix__flush_tlb_range_psize-as-__always_inline.patch
powerpc-mm-radix-mark-as-__tlbie_pid-and-friends-as__always_inline.patch
compiler-allow-all-arches-to-enable-config_optimize_inlining.patch
treewide-replace-include-asm-sizesh-with-include-linux-sizesh.patch
arch-remove-asm-sizesh-amd-asm-generic-sizesh.patch




[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux