The patch titled Subject: fpga/dlf/afu: drop mmap_sem now that locked_vm is atomic has been added to the -mm tree. Its filename is fpga-dlf-afu-drop-mmap_sem-now-that-locked_vm-is-atomic.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/fpga-dlf-afu-drop-mmap_sem-now-that-locked_vm-is-atomic.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/fpga-dlf-afu-drop-mmap_sem-now-that-locked_vm-is-atomic.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx> Subject: fpga/dlf/afu: drop mmap_sem now that locked_vm is atomic With locked_vm now an atomic, there is no need to take mmap_sem as writer. Delete and refactor accordingly. Link: http://lkml.kernel.org/r/20190402204158.27582-5-daniel.m.jordan@xxxxxxxxxx Signed-off-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx> Cc: Alan Tull <atull@xxxxxxxxxx> Cc: Christoph Lameter <cl@xxxxxxxxx> Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx> Cc: Moritz Fischer <mdf@xxxxxxxxxx> Cc: Wu Hao <hao.wu@xxxxxxxxx> Cc: Alexey Kardashevskiy <aik@xxxxxxxxx> Cc: Alex Williamson <alex.williamson@xxxxxxxxxx> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> Cc: Ira Weiny <ira.weiny@xxxxxxxxx> Cc: Jason Gunthorpe <jgg@xxxxxxxxxxxx> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx> Cc: Paul Mackerras <paulus@xxxxxxxxxx> Cc: Paul Mackerras <paulus@xxxxxxxxx> Cc: Mark Rutland <mark.rutland@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/fpga/dfl-afu-dma-region.c | 40 ++++++++++------------------ 1 file changed, 15 insertions(+), 25 deletions(-) --- a/drivers/fpga/dfl-afu-dma-region.c~fpga-dlf-afu-drop-mmap_sem-now-that-locked_vm-is-atomic +++ a/drivers/fpga/dfl-afu-dma-region.c @@ -35,46 +35,36 @@ void afu_dma_region_init(struct dfl_feat * afu_dma_adjust_locked_vm - adjust locked memory * @dev: port device * @npages: number of pages - * @incr: increase or decrease locked memory * * Increase or decrease the locked memory size with npages input. * * Return 0 on success. * Return -ENOMEM if locked memory size is over the limit and no CAP_IPC_LOCK. */ -static int afu_dma_adjust_locked_vm(struct device *dev, long npages, bool incr) +static int afu_dma_adjust_locked_vm(struct device *dev, long pages) { - unsigned long locked, lock_limit; + unsigned long lock_limit; s64 locked_vm; int ret = 0; /* the task is exiting. */ - if (!current->mm) + if (!current->mm || !pages) return 0; - down_write(¤t->mm->mmap_sem); - - locked_vm = atomic64_read(¤t->mm->locked_vm); - if (incr) { - locked = locked_vm + npages; + locked_vm = atomic64_add_return(pages, ¤t->mm->locked_vm); + WARN_ON_ONCE(locked_vm < 0); + if (pages > 0 && !capable(CAP_IPC_LOCK)) { lock_limit = rlimit(RLIMIT_MEMLOCK) >> PAGE_SHIFT; - - if (locked > lock_limit && !capable(CAP_IPC_LOCK)) + if (locked_vm > lock_limit) { ret = -ENOMEM; - else - atomic64_add(npages, ¤t->mm->locked_vm); - } else { - if (WARN_ON_ONCE(npages > locked_vm)) - npages = locked_vm; - atomic64_sub(npages, ¤t->mm->locked_vm); + atomic64_sub(pages, ¤t->mm->locked_vm); + } } dev_dbg(dev, "[%d] RLIMIT_MEMLOCK %c%ld %lld/%lu%s\n", current->pid, - incr ? '+' : '-', npages << PAGE_SHIFT, - (s64)atomic64_read(¤t->mm->locked_vm) << PAGE_SHIFT, - rlimit(RLIMIT_MEMLOCK), ret ? "- exceeded" : ""); - - up_write(¤t->mm->mmap_sem); + (pages > 0) ? '+' : '-', pages << PAGE_SHIFT, + locked_vm << PAGE_SHIFT, rlimit(RLIMIT_MEMLOCK), + ret ? "- exceeded" : ""); return ret; } @@ -94,7 +84,7 @@ static int afu_dma_pin_pages(struct dfl_ struct device *dev = &pdata->dev->dev; int ret, pinned; - ret = afu_dma_adjust_locked_vm(dev, npages, true); + ret = afu_dma_adjust_locked_vm(dev, npages); if (ret) return ret; @@ -123,7 +113,7 @@ put_pages: free_pages: kfree(region->pages); unlock_vm: - afu_dma_adjust_locked_vm(dev, npages, false); + afu_dma_adjust_locked_vm(dev, -npages); return ret; } @@ -143,7 +133,7 @@ static void afu_dma_unpin_pages(struct d put_all_pages(region->pages, npages); kfree(region->pages); - afu_dma_adjust_locked_vm(dev, npages, false); + afu_dma_adjust_locked_vm(dev, -npages); dev_dbg(dev, "%ld pages unpinned\n", npages); } _ Patches currently in -mm which might be from daniel.m.jordan@xxxxxxxxxx are mm-change-locked_vms-type-from-unsigned-long-to-atomic64_t.patch vfio-type1-drop-mmap_sem-now-that-locked_vm-is-atomic.patch vfio-spapr_tce-drop-mmap_sem-now-that-locked_vm-is-atomic.patch fpga-dlf-afu-drop-mmap_sem-now-that-locked_vm-is-atomic.patch powerpc-mmu-drop-mmap_sem-now-that-locked_vm-is-atomic.patch kvm-book3s-drop-mmap_sem-now-that-locked_vm-is-atomic.patch