The patch titled
Subject: kernel, resource: use resource_overlaps() to simplify region_intersects()
has been added to the -mm tree. Its filename is
kernel-resource-use-resource_overlaps-to-simplify-region_intersects.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/kernel-resource-use-resource_overlaps-to-simplify-region_intersects.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/kernel-resource-use-resource_overlaps-to-simplify-region_intersects.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Wei Yang <richardw.yang@xxxxxxxxxxxxxxx>
Subject: kernel, resource: use resource_overlaps() to simplify region_intersects()
The three checks in region_intersects() are to see whether two resources
overlap. This means it could be simplified with one resource_overlaps().
Also fix two typos in related function.
Link: http://lkml.kernel.org/r/20190305083432.23675-1-richardw.yang@xxxxxxxxxxxxxxx
Signed-off-by: Wei Yang <richardw.yang@xxxxxxxxxxxxxxx>
Reviewed-by: Like Xu <like.xu@xxxxxxxxxxxxxxx>
Reviewed-by: Yuan Yao <yuan.yao@xxxxxxxxxxxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Cc: Borislav Petkov <bp@xxxxxxx>
Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Takashi Iwai <tiwai@xxxxxxx>
Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/iomem.c | 4 ++--
kernel/resource.c | 11 +++++------
2 files changed, 7 insertions(+), 8 deletions(-)
--- a/kernel/iomem.c~kernel-resource-use-resource_overlaps-to-simplify-region_intersects
+++ a/kernel/iomem.c
@@ -55,7 +55,7 @@ static void *try_ram_remap(resource_size
*
* MEMREMAP_WB - matches the default mapping for System RAM on
* the architecture. This is usually a read-allocate write-back cache.
- * Morever, if MEMREMAP_WB is specified and the requested remap region is RAM
+ * Moreover, if MEMREMAP_WB is specified and the requested remap region is RAM
* memremap() will bypass establishing a new mapping and instead return
* a pointer into the direct map.
*
@@ -86,7 +86,7 @@ void *memremap(resource_size_t offset, s
/* Try all mapping types requested until one returns non-NULL */
if (flags & MEMREMAP_WB) {
/*
- * MEMREMAP_WB is special in that it can be satisifed
+ * MEMREMAP_WB is special in that it can be satisfied
* from the direct map. Some archs depend on the
* capability of memremap() to autodetect cases where
* the requested range is potentially in System RAM.
--- a/kernel/resource.c~kernel-resource-use-resource_overlaps-to-simplify-region_intersects
+++ a/kernel/resource.c
@@ -520,21 +520,20 @@ EXPORT_SYMBOL_GPL(page_is_ram);
int region_intersects(resource_size_t start, size_t size, unsigned long flags,
unsigned long desc)
{
- resource_size_t end = start + size - 1;
+ struct resource res;
int type = 0; int other = 0;
struct resource *p;
+ res.start = start;
+ res.end = start + size - 1;
+
read_lock(&resource_lock);
for (p = iomem_resource.child; p ; p = p->sibling) {
bool is_type = (((p->flags & flags) == flags) &&
((desc == IORES_DESC_NONE) ||
(desc == p->desc)));
- if (start >= p->start && start <= p->end)
- is_type ? type++ : other++;
- if (end >= p->start && end <= p->end)
- is_type ? type++ : other++;
- if (p->start >= start && p->end <= end)
+ if (resource_overlaps(p, &res))
is_type ? type++ : other++;
}
read_unlock(&resource_lock);
_
Patches currently in -mm which might be from richardw.yang@xxxxxxxxxxxxxxx are
kernel-resource-use-resource_overlaps-to-simplify-region_intersects.patch
